From 6e1032f9af8de059f085fd03054020a834bb05fa Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Tue, 24 Dec 2024 05:23:32 -0800 Subject: [PATCH] Nit fix to LogProcessor tests (#2467) --- opentelemetry-otlp/tests/integration_test/tests/logs.rs | 4 ++-- .../tests/integration_test/tests/traces.rs | 2 +- opentelemetry-sdk/src/logs/log_processor.rs | 9 +++------ 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/opentelemetry-otlp/tests/integration_test/tests/logs.rs b/opentelemetry-otlp/tests/integration_test/tests/logs.rs index 39eb88a1e4..81537b7ff5 100644 --- a/opentelemetry-otlp/tests/integration_test/tests/logs.rs +++ b/opentelemetry-otlp/tests/integration_test/tests/logs.rs @@ -94,7 +94,7 @@ mod logtests { tokio::time::sleep(Duration::from_secs(10)).await; - assert_logs_results(test_utils::LOGS_FILE, "expected/logs.json"); + assert_logs_results(test_utils::LOGS_FILE, "expected/logs.json")?; Ok(()) } @@ -122,7 +122,7 @@ mod logtests { } let _ = logger_provider.shutdown(); // tokio::time::sleep(Duration::from_secs(10)).await; - assert_logs_results(test_utils::LOGS_FILE, "expected/logs.json"); + assert_logs_results(test_utils::LOGS_FILE, "expected/logs.json")?; Ok(()) } diff --git a/opentelemetry-otlp/tests/integration_test/tests/traces.rs b/opentelemetry-otlp/tests/integration_test/tests/traces.rs index 29bc93d77f..92816c0333 100644 --- a/opentelemetry-otlp/tests/integration_test/tests/traces.rs +++ b/opentelemetry-otlp/tests/integration_test/tests/traces.rs @@ -13,7 +13,7 @@ use anyhow::Result; use ctor::dtor; use integration_test_runner::test_utils; use opentelemetry_proto::tonic::trace::v1::TracesData; -use opentelemetry_sdk::{runtime, trace as sdktrace, Resource}; +use opentelemetry_sdk::{trace as sdktrace, Resource}; use std::fs::File; use std::io::Write; use std::os::unix::fs::MetadataExt; diff --git a/opentelemetry-sdk/src/logs/log_processor.rs b/opentelemetry-sdk/src/logs/log_processor.rs index 9d78383e8b..999044bc68 100644 --- a/opentelemetry-sdk/src/logs/log_processor.rs +++ b/opentelemetry-sdk/src/logs/log_processor.rs @@ -152,14 +152,11 @@ impl LogProcessor for SimpleLogProcessor { #[allow(clippy::large_enum_variant)] #[derive(Debug)] enum BatchMessage { - /// Export logs, usually called when the log is emitted. + /// Export logs, called when the log is emitted. ExportLog(Box<(LogRecord, InstrumentationScope)>), - /// Flush the current buffer to the backend, it can be triggered by - /// pre configured interval or a call to `force_push` function. - // Flush(Option>), - /// ForceFlush flushes the current buffer to the backend. + /// ForceFlush flushes the current buffer to the exporter. ForceFlush(mpsc::SyncSender), - /// Shut down the worker thread, push all logs in buffer to the backend. + /// Shut down the worker thread, push all logs in buffer to the exporter. Shutdown(mpsc::SyncSender), /// Set the resource for the exporter. SetResource(Arc),