Skip to content

Commit 6c88d31

Browse files
Use opentelemetry:time::now instead of systemtime (#2595)
1 parent a81ad24 commit 6c88d31

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

opentelemetry-prometheus/examples/hyper.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use opentelemetry_sdk::metrics::SdkMeterProvider;
1515
use prometheus::{Encoder, Registry, TextEncoder};
1616
use std::net::SocketAddr;
1717
use std::sync::Arc;
18-
use std::time::SystemTime;
18+
use opentelemetry::time::now;
1919
use tokio::net::TcpListener;
2020

2121
static HANDLER_ALL: Lazy<[KeyValue; 1]> = Lazy::new(|| [KeyValue::new("handler", "all")]);
@@ -25,7 +25,7 @@ async fn serve_req(
2525
state: Arc<AppState>,
2626
) -> Result<Response<Full<Bytes>>, hyper::Error> {
2727
println!("Receiving request at path {}", req.uri());
28-
let request_start = SystemTime::now();
28+
let request_start = now();
2929

3030
state.http_counter.add(1, HANDLER_ALL.as_ref());
3131

opentelemetry-sdk/benches/batch_span_processor.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
2+
use opentelemetry::time::now;
23
use opentelemetry::trace::{
34
SpanContext, SpanId, SpanKind, Status, TraceFlags, TraceId, TraceState,
45
};
@@ -8,7 +9,6 @@ use opentelemetry_sdk::trace::{
89
BatchConfigBuilder, BatchSpanProcessor, SpanEvents, SpanLinks, SpanProcessor,
910
};
1011
use std::sync::Arc;
11-
use std::time::SystemTime;
1212
use tokio::runtime::Runtime;
1313

1414
fn get_span_data() -> Vec<SpanData> {
@@ -24,8 +24,8 @@ fn get_span_data() -> Vec<SpanData> {
2424
parent_span_id: SpanId::from_u64(12),
2525
span_kind: SpanKind::Client,
2626
name: Default::default(),
27-
start_time: SystemTime::now(),
28-
end_time: SystemTime::now(),
27+
start_time: now(),
28+
end_time: now(),
2929
attributes: Vec::new(),
3030
dropped_attributes_count: 0,
3131
events: SpanEvents::default(),

opentelemetry-sdk/benches/log.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ RAM: 64.0 GB
1515
| Logging_Comparable_To_Appender | 87 ns |
1616
*/
1717

18+
use opentelemetry::time::now;
1819
use std::collections::HashMap;
19-
use std::time::SystemTime;
2020

2121
use criterion::{criterion_group, criterion_main, Criterion};
2222

@@ -111,7 +111,7 @@ fn logging_comparable_to_appender(c: &mut Criterion) {
111111
c.bench_function("Logging_Comparable_To_Appender", |b| {
112112
b.iter(|| {
113113
let mut log_record = logger.create_log_record();
114-
let now = SystemTime::now();
114+
let now = now();
115115
log_record.set_observed_timestamp(now);
116116
log_record.set_target("my-target".to_string());
117117
log_record.set_event_name("CheckoutFailed");
@@ -253,7 +253,7 @@ fn criterion_benchmark(c: &mut Criterion) {
253253
logger.emit(log_record);
254254
});
255255

256-
let now = SystemTime::now();
256+
let now = now();
257257
log_benchmark_group(c, "full-log", |logger| {
258258
let mut log_record = logger.create_log_record();
259259
log_record.set_body("full log".into());

opentelemetry-sdk/benches/log_exporter.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
| LogExporterWithoutFuture | 92 ns |
1111
*/
1212

13+
use opentelemetry::time::now;
1314
use std::sync::Mutex;
14-
use std::time::SystemTime;
1515

1616
use async_trait::async_trait;
1717
use criterion::{criterion_group, criterion_main, Criterion};
@@ -126,7 +126,7 @@ fn exporter_with_future(c: &mut Criterion) {
126126
c.bench_function("LogExporterWithFuture", |b| {
127127
b.iter(|| {
128128
let mut log_record = logger.create_log_record();
129-
let now = SystemTime::now();
129+
let now = now();
130130
log_record.set_observed_timestamp(now);
131131
log_record.set_target("my-target".to_string());
132132
log_record.set_event_name("CheckoutFailed");
@@ -152,7 +152,7 @@ fn exporter_without_future(c: &mut Criterion) {
152152
c.bench_function("LogExporterWithoutFuture", |b| {
153153
b.iter(|| {
154154
let mut log_record = logger.create_log_record();
155-
let now = SystemTime::now();
155+
let now = now();
156156
log_record.set_observed_timestamp(now);
157157
log_record.set_target("my-target".to_string());
158158
log_record.set_event_name("CheckoutFailed");

opentelemetry-sdk/benches/log_processor.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
| log_clone_and_send_to_channel_processor | 403 ns |
1212
*/
1313

14+
use opentelemetry::time::now;
1415
use std::{
1516
sync::{Arc, Mutex},
1617
thread::sleep,
17-
time::SystemTime,
1818
};
1919

2020
use criterion::{criterion_group, criterion_main, Criterion};
@@ -29,7 +29,7 @@ use opentelemetry_sdk::logs::{LogProcessor, LogRecord, LogResult, Logger, Logger
2929

3030
fn create_log_record(logger: &Logger) -> LogRecord {
3131
let mut log_record = logger.create_log_record();
32-
let now = SystemTime::now();
32+
let now = now();
3333
log_record.set_observed_timestamp(now);
3434
log_record.set_target("my-target".to_string());
3535
log_record.set_event_name("CheckoutFailed");

0 commit comments

Comments
 (0)