Skip to content

Commit 500fdfc

Browse files
authored
Nit fixes to md file to reduce warnings (#1364)
1 parent ddfe9ff commit 500fdfc

File tree

6 files changed

+67
-45
lines changed

6 files changed

+67
-45
lines changed

.cspell.json

+20
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,33 @@
2525
// these are words that are always correct and can be thought of as our
2626
// workspace dictionary.
2727
"words": [
28+
"actix",
29+
"appender",
30+
"appenders",
31+
"Bhasin",
32+
"Cijo",
33+
"codecov",
2834
"deque",
35+
"Dirkjan",
2936
"hasher",
37+
"isahc",
38+
"Isobel",
39+
"jaegertracing",
40+
"Kühle",
41+
"Kumar",
42+
"Lalit",
3043
"msrv",
44+
"Ochtman",
45+
"openetelemetry",
3146
"opentelemetry",
3247
"OTLP",
48+
"protoc",
3349
"quantile",
50+
"Redelmeier",
51+
"reqwest",
3452
"rustc",
53+
"Tescher",
54+
"Zhongyang",
3555
"zipkin"
3656
],
3757
"enabledLanguageIds": [

.github/workflows/ci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ on:
66
push:
77
branches:
88
- main
9+
paths-ignore:
10+
- '**.md'
911
jobs:
1012
test:
1113
strategy:

CODEOWNERS

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
# Code owners file.
2-
# This file controls who is tagged for review for any given pull request.
1+
# Code owners file
32

4-
# For anything not explicitly taken by someone else:
5-
* @open-telemetry/rust-approvers
3+
## This file controls who is tagged for review for any given pull request.
4+
5+
## For anything not explicitly taken by someone else:
6+
7+
* @open-telemetry/rust-approvers

CONTRIBUTING.md

+21-21
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ you're more than welcome to participate!
2121

2222
### Prerequisites
2323

24-
Crate `opentelemetry-otlp` uses gRPC + Protocol Buffers.<br>
24+
Crate `opentelemetry-otlp` uses gRPC + Protocol Buffers.
2525
You can provide the protocol compiler protoc path programmatically (only works with tonic) or build it from source
2626

2727
```sh
@@ -40,13 +40,13 @@ Everyone is welcome to contribute code to `opentelemetry-rust` via
4040
GitHub pull requests (PRs).
4141

4242
```sh
43-
$ git clone --recurse-submodule https://github.com/open-telemetry/opentelemetry-rust
43+
git clone --recurse-submodule https://github.com/open-telemetry/opentelemetry-rust
4444
```
4545

4646
Enter the newly created directory and add your fork as a new remote:
4747

4848
```sh
49-
$ git remote add <YOUR_FORK> git@github.com:<YOUR_GITHUB_USERNAME>/opentelemetry-rust
49+
git remote add <YOUR_FORK> git@github.com:<YOUR_GITHUB_USERNAME>/opentelemetry-rust
5050
```
5151

5252
Check out a new branch, make modifications, run linters and tests, and
@@ -70,25 +70,25 @@ the repo to catch any issues locally.
7070

7171
### How to Receive Comments
7272

73-
* If the PR is not ready for review, please put `[WIP]` in the title or mark it
73+
- If the PR is not ready for review, please put `[WIP]` in the title or mark it
7474
as [`draft`](https://github.blog/2019-02-14-introducing-draft-pull-requests/).
75-
* Make sure CLA is signed and all required CI checks are clear.
76-
* Submit small, focused PRs addressing a single concern/issue.
77-
* Make sure the PR title reflects the contribution.
78-
* Write a summary that helps understand the change.
79-
* Include usage examples in the summary, where applicable.
80-
* Include benchmarks (before/after) in the summary, for contributions that are
75+
- Make sure CLA is signed and all required CI checks are clear.
76+
- Submit small, focused PRs addressing a single concern/issue.
77+
- Make sure the PR title reflects the contribution.
78+
- Write a summary that helps understand the change.
79+
- Include usage examples in the summary, where applicable.
80+
- Include benchmarks (before/after) in the summary, for contributions that are
8181
performance enhancements.
8282

8383
### How to Get PRs Merged
8484

8585
A PR is considered to be **ready to merge** when:
8686

87-
* It has received approval from
87+
- It has received approval from
8888
[Approvers](https://github.com/open-telemetry/community/blob/main/community-membership.md#approver).
8989
/
9090
[Maintainers](https://github.com/open-telemetry/community/blob/main/community-membership.md#maintainer).
91-
* Major feedbacks are resolved.
91+
- Major feedbacks are resolved.
9292

9393
Any Maintainer can merge the PR once it is **ready to merge**. Note, that some
9494
PRs may not be merged immediately if the repo is in the process of a release and
@@ -124,7 +124,7 @@ For a deeper discussion, see:
124124

125125
### Error Handling
126126

127-
Currently, the Opentelemetry Rust SDK has two ways to handle errors. In the situation where errors are not allowed to return. One should call global error handler to process the errors. Otherwise, one should return the errors.
127+
Currently, the Opentelemetry Rust SDK has two ways to handle errors. In the situation where errors are not allowed to return. One should call global error handler to process the errors. Otherwise, one should return the errors.
128128

129129
The Opentelemetry Rust SDK comes with an error type `openetelemetry::Error`. For different function, one error has been defined. All error returned by trace module MUST be wrapped in `opentelemetry::trace::TraceError`. All errors returned by metrics module MUST be wrapped in `opentelemetry::metrics::MetricsError`.
130130

@@ -139,17 +139,17 @@ OpenTelemetry supports multiple ways to configure the API, SDK and other compone
139139

140140
## Style Guide
141141

142-
* Run `cargo clippy --all` - this will catch common mistakes and improve
142+
- Run `cargo clippy --all` - this will catch common mistakes and improve
143143
your Rust code
144-
* Run `cargo fmt` - this will find and fix code formatting
144+
- Run `cargo fmt` - this will find and fix code formatting
145145
issues.
146146

147147
## Testing and Benchmarking
148148

149-
* Run `cargo test --all` - this will execute code and doc tests for all
149+
- Run `cargo test --all` - this will execute code and doc tests for all
150150
projects in this workspace.
151-
* Run `cargo bench` - this will run benchmarks to show performance
152-
* Run `cargo bench` - this will run benchmarks to show performance
151+
- Run `cargo bench` - this will run benchmarks to show performance
152+
- Run `cargo bench` - this will run benchmarks to show performance
153153
regressions
154154

155155
## Approvers and Maintainers
@@ -170,9 +170,9 @@ For GitHub groups see the [code owners](CODEOWNERS) file.
170170

171171
### Emeritus
172172

173-
* [Dirkjan Ochtman](https://github.com/djc)
174-
* [Jan Kühle](https://github.com/frigus02)
175-
* [Isobel Redelmeier](https://github.com/iredelmeier)
173+
- [Dirkjan Ochtman](https://github.com/djc)
174+
- [Jan Kühle](https://github.com/frigus02)
175+
- [Isobel Redelmeier](https://github.com/iredelmeier)
176176

177177
### Become an Approver or a Maintainer
178178

README.md

+16-18
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ observability tools.
3131
[Jaeger]: https://www.jaegertracing.io
3232
[msrv]: #supported-rust-versions
3333

34-
3534
## Project Status
3635

3736
| Signal | Status |
@@ -101,36 +100,36 @@ adapter crates to assist in propagating state and instrumenting applications.
101100

102101
In particular, the following crates are likely to be of interest:
103102

104-
- [`opentelemetry-aws`] provides unofficial propagators for AWS X-ray.
105-
- [`opentelemetry-datadog`] provides additional exporters to [`Datadog`].
106-
- [`opentelemetry-dynatrace`] provides additional exporters to Dynatrace.
107-
- [`opentelemetry-contrib`] provides additional exporters and propagators that
103+
* [`opentelemetry-aws`] provides unofficial propagators for AWS X-ray.
104+
* [`opentelemetry-datadog`] provides additional exporters to [`Datadog`].
105+
* [`opentelemetry-dynatrace`] provides additional exporters to Dynatrace.
106+
* [`opentelemetry-contrib`] provides additional exporters and propagators that
108107
are experimental.
109-
- [`opentelemetry-http`] provides an interface for injecting and extracting
108+
* [`opentelemetry-http`] provides an interface for injecting and extracting
110109
trace information from [`http`] headers.
111-
- [`opentelemetry-jaeger`] provides a pipeline and exporter for sending trace
110+
* [`opentelemetry-jaeger`] provides a pipeline and exporter for sending trace
112111
information to [`Jaeger`].
113-
- [`opentelemetry-otlp`] exporter for sending trace and metric data in the OTLP
112+
* [`opentelemetry-otlp`] exporter for sending trace and metric data in the OTLP
114113
format to the OpenTelemetry collector.
115-
- [`opentelemetry-prometheus`] provides a pipeline and exporter for sending
114+
* [`opentelemetry-prometheus`] provides a pipeline and exporter for sending
116115
metrics information to [`Prometheus`].
117-
- [`opentelemetry-semantic-conventions`] provides standard names and semantic
116+
* [`opentelemetry-semantic-conventions`] provides standard names and semantic
118117
otel conventions.
119-
- [`opentelemetry-stackdriver`] provides an exporter for Google's [Cloud Trace]
118+
* [`opentelemetry-stackdriver`] provides an exporter for Google's [Cloud Trace]
120119
(which used to be called StackDriver).
121-
- [`opentelemetry-zipkin`] provides a pipeline and exporter for sending trace
120+
* [`opentelemetry-zipkin`] provides a pipeline and exporter for sending trace
122121
information to [`Zipkin`].
123122

124123
Additionally, there are also several third-party crates which are not
125124
maintained by the `opentelemetry` project. These include:
126125

127-
- [`tracing-opentelemetry`] provides integration for applications instrumented
126+
* [`tracing-opentelemetry`] provides integration for applications instrumented
128127
using the [`tracing`] API and ecosystem.
129-
- [`actix-web-opentelemetry`] provides integration for the [`actix-web`] web
128+
* [`actix-web-opentelemetry`] provides integration for the [`actix-web`] web
130129
server and ecosystem.
131-
- [`opentelemetry-application-insights`] provides an unofficial [Azure
130+
* [`opentelemetry-application-insights`] provides an unofficial [Azure
132131
Application Insights] exporter.
133-
- [`opentelemetry-tide`] provides integration for the [`Tide`] web server and
132+
* [`opentelemetry-tide`] provides integration for the [`Tide`] web server and
134133
ecosystem.
135134

136135
If you're the maintainer of an `opentelemetry` ecosystem crate not listed
@@ -149,7 +148,6 @@ above, please let us know! We'd love to add your project to the list!
149148
[`opentelemetry-contrib`]: https://crates.io/crates/opentelemetry-contrib
150149
[`Datadog`]: https://www.datadoghq.com
151150
[`opentelemetry-datadog`]: https://crates.io/crates/opentelemetry-datadog
152-
[`Dynatrace`]: https://www.dynatrace.com/
153151
[`opentelemetry-dynatrace`]: https://crates.io/crates/opentelemetry-dynatrace
154152
[`opentelemetry-semantic-conventions`]: https://crates.io/crates/opentelemetry-semantic-conventions
155153
[`http`]: https://crates.io/crates/http
@@ -182,7 +180,7 @@ this policy.
182180

183181
See the [contributing file](CONTRIBUTING.md).
184182

185-
The Rust special interest group (SIG) meets weekly on Tuesdays at 9 AM Pacific
183+
The Rust special interest group (SIG) meets weekly on Tuesdays at 8 AM Pacific
186184
Time (16:00 UTC). The meeting is subject to change depending on contributors'
187185
availability. Check the [OpenTelemetry community
188186
calendar](https://calendar.google.com/calendar/embed?src=google.com_b79e3e90j7bbsa2n2p5an5lf60%40group.calendar.google.com)

opentelemetry-jaeger/src/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@
151151
//! You can set it using one of the following methods from highest priority to lowest priority.
152152
//! 1. [`with_service_name`].
153153
//! 2. include a `service.name` key value pairs when configure resource using [`with_trace_config`].
154-
//! 3. set the service name as `OTEL_SERVCE_NAME` environment variable.
154+
//! 3. set the service name as `OTEL_SERVICE_NAME` environment variable.
155155
//! 4. set the `service.name` attributes in `OTEL_RESOURCE_ATTRIBUTES`.
156156
//! 5. if the service name is not provided by the above method. `unknown_service` will be used.
157157
//!
@@ -207,7 +207,7 @@
207207
//! ```
208208
//!
209209
//! ### Export to collectors
210-
//! Note that this example requires `collecotr_client` and `isahc_collector_client` feature.
210+
//! Note that this example requires `collector_client` and `isahc_collector_client` feature.
211211
//! ```ignore
212212
//! use opentelemetry::{global, KeyValue, trace::{Tracer, TraceError}};
213213
//! use opentelemetry_sdk::{trace::{config, RandomIdGenerator, Sampler}, Resource};

0 commit comments

Comments
 (0)