You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any Maintainer can merge the PR once it is **ready to merge**. Note, that some
94
94
PRs may not be merged immediately if the repo is in the process of a release and
@@ -124,7 +124,7 @@ For a deeper discussion, see:
124
124
125
125
### Error Handling
126
126
127
-
Currently, the Opentelemetry Rust SDK has two ways to handle errors. In the situation where errors are not allowed to return. One should call global error handler to process the errors. Otherwise, one should return the errors.
127
+
Currently, the Opentelemetry Rust SDK has two ways to handle errors. In the situation where errors are not allowed to return. One should call global error handler to process the errors. Otherwise, one should return the errors.
128
128
129
129
The Opentelemetry Rust SDK comes with an error type `openetelemetry::Error`. For different function, one error has been defined. All error returned by trace module MUST be wrapped in `opentelemetry::trace::TraceError`. All errors returned by metrics module MUST be wrapped in `opentelemetry::metrics::MetricsError`.
130
130
@@ -139,17 +139,17 @@ OpenTelemetry supports multiple ways to configure the API, SDK and other compone
139
139
140
140
## Style Guide
141
141
142
-
* Run `cargo clippy --all` - this will catch common mistakes and improve
142
+
- Run `cargo clippy --all` - this will catch common mistakes and improve
143
143
your Rust code
144
-
* Run `cargo fmt` - this will find and fix code formatting
144
+
- Run `cargo fmt` - this will find and fix code formatting
145
145
issues.
146
146
147
147
## Testing and Benchmarking
148
148
149
-
* Run `cargo test --all` - this will execute code and doc tests for all
149
+
- Run `cargo test --all` - this will execute code and doc tests for all
150
150
projects in this workspace.
151
-
* Run `cargo bench` - this will run benchmarks to show performance
152
-
* Run `cargo bench` - this will run benchmarks to show performance
151
+
- Run `cargo bench` - this will run benchmarks to show performance
152
+
- Run `cargo bench` - this will run benchmarks to show performance
153
153
regressions
154
154
155
155
## Approvers and Maintainers
@@ -170,9 +170,9 @@ For GitHub groups see the [code owners](CODEOWNERS) file.
0 commit comments