Skip to content

Commit 4afe983

Browse files
committed
opentelemetry-otlp: Default the port correctly.
Current behavior uses http-proto port even when there's no desire to use it. Relates #1509 Signed-off-by: Harold Dost <h.dost@criteo.com>
1 parent 1be83bb commit 4afe983

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

opentelemetry-otlp/CHANGELOG.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,14 @@
22

33
## vNext
44

5-
- **Breaking** Remove support for surf HTTP client [#1537](https://github.com/open-telemetry/opentelemetry-rust/pull/1537)
5+
### Fixed
6+
- Fix `tonic()` to the use correct port. [#1556](https://github.com/open-telemetry/opentelemetry-rust/pull/1556)
7+
8+
### Changed
69
- Update to tonic 0.11 and prost 0.12 (#1536)
10+
11+
### Removed
12+
- **Breaking** Remove support for surf HTTP client [#1537](https://github.com/open-telemetry/opentelemetry-rust/pull/1537)
713
- Remove support for grpcio transport (#1534)
814

915
## v0.14.0

opentelemetry-otlp/src/exporter/tonic/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ impl Default for TonicExporterBuilder {
149149
TonicExporterBuilder {
150150
exporter_config: ExportConfig {
151151
protocol: crate::Protocol::Grpc,
152+
endpoint: crate::exporter::default_endpoint(crate::Protocol::Grpc),
152153
..Default::default()
153154
},
154155
tonic_config,

opentelemetry-otlp/tests/integration_test/tests/traces.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ use opentelemetry::{
66
trace::{TraceContextExt, Tracer},
77
Key, KeyValue,
88
};
9-
use opentelemetry_otlp::WithExportConfig;
109
use opentelemetry_sdk::{runtime, trace as sdktrace, Resource};
1110
use std::error::Error;
1211
use std::fs::File;
@@ -17,8 +16,7 @@ fn init_tracer() -> Result<sdktrace::Tracer, TraceError> {
1716
.tracing()
1817
.with_exporter(
1918
opentelemetry_otlp::new_exporter()
20-
.tonic()
21-
.with_endpoint("http://localhost:4317"),
19+
.tonic(),
2220
)
2321
.with_trace_config(
2422
sdktrace::config().with_resource(Resource::new(vec![KeyValue::new(

0 commit comments

Comments
 (0)