Skip to content

Commit 42f86ea

Browse files
committed
Address PR comments
1 parent b53d704 commit 42f86ea

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

opentelemetry-otlp/src/lib.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@
125125
//! # #[cfg(feature = "metrics")]
126126
//! use opentelemetry_sdk::metrics::reader::{DefaultAggregationSelector, DefaultTemporalitySelector};
127127
//! use opentelemetry_otlp::{Protocol, WithExportConfig, ExportConfig};
128-
//! use opentelemetry::trace::TracerProvider;
129128
//! use std::time::Duration;
130129
//! # #[cfg(feature = "grpc-tonic")]
131130
//! use tonic::metadata::*;
@@ -158,8 +157,8 @@
158157
//! .with_resource(Resource::new(vec![KeyValue::new("service.name", "example")])),
159158
//! )
160159
//! .install_batch(opentelemetry_sdk::runtime::Tokio)?;
161-
//! global::set_tracer_provider(tracer_provider.clone());
162-
//! let tracer = global::tracer_provider().tracer_builder("opentelemetry-otlp").build();
160+
//! global::set_tracer_provider(tracer_provider);
161+
//! let tracer = global::tracer("tracer-name");
163162
//! # tracer
164163
//! # };
165164
//!

opentelemetry-otlp/tests/smoke.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use futures_util::StreamExt;
22
use opentelemetry::global;
33
use opentelemetry::global::shutdown_tracer_provider;
4-
use opentelemetry::trace::{Span, SpanKind, Tracer, TracerProvider};
4+
use opentelemetry::trace::{Span, SpanKind, Tracer};
55
use opentelemetry_otlp::WithExportConfig;
66
use opentelemetry_proto::tonic::collector::trace::v1::{
77
trace_service_server::{TraceService, TraceServiceServer},
@@ -102,9 +102,9 @@ async fn smoke_tracer() {
102102
.install_batch(opentelemetry_sdk::runtime::Tokio)
103103
.expect("failed to install");
104104

105-
global::set_tracer_provider(tracer_provider.clone());
105+
global::set_tracer_provider(tracer_provider);
106106

107-
let tracer = global::tracer_provider().tracer_builder("smoke").build();
107+
let tracer = global::tracer("smoke");
108108

109109
println!("Sending span...");
110110
let mut span = tracer

0 commit comments

Comments
 (0)