Skip to content

Commit 4030ddd

Browse files
committed
Fix some lints
1 parent 06c8f64 commit 4030ddd

File tree

6 files changed

+9
-8
lines changed

6 files changed

+9
-8
lines changed

opentelemetry-jaeger/src/exporter/config/collector/http_client.rs

+1
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ pub(crate) mod test_http_client {
119119
use opentelemetry_http::{HttpClient, HttpError};
120120
use std::fmt::Debug;
121121

122+
#[allow(unused)]
122123
pub(crate) struct TestHttpClient;
123124

124125
impl Debug for TestHttpClient {

opentelemetry-sdk/src/logs/log_emitter.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ mod tests {
274274
use opentelemetry::{Key, KeyValue, Value};
275275
use std::fmt::{Debug, Formatter};
276276
use std::sync::atomic::AtomicU64;
277-
use std::sync::{Arc, Mutex};
277+
use std::sync::Mutex;
278278
use std::thread;
279279

280280
struct ShutdownTestLogProcessor {

opentelemetry-sdk/src/metrics/periodic_reader.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use futures_util::{
99
future::{self, Either},
1010
pin_mut,
1111
stream::{self, FusedStream},
12-
Stream, StreamExt,
12+
StreamExt,
1313
};
1414
use opentelemetry::{
1515
global,
@@ -290,7 +290,7 @@ impl<RT: Runtime> PeriodicReaderWorker<RT> {
290290
true
291291
}
292292

293-
async fn run(mut self, mut messages: impl Stream<Item = Message> + Unpin + FusedStream) {
293+
async fn run(mut self, mut messages: impl FusedStream<Item = Message> + Unpin) {
294294
while let Some(message) = messages.next().await {
295295
if !self.process_message(message).await {
296296
break;

opentelemetry-sdk/src/metrics/pipeline.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,8 @@ impl SdkProducer for Pipeline {
165165
// previous aggregation was of a different type
166166
prev_agg.data = data;
167167
}
168-
prev_agg.name = inst.name.clone();
169-
prev_agg.description = inst.description.clone();
168+
prev_agg.name.clone_from(&inst.name);
169+
prev_agg.description.clone_from(&inst.description);
170170
prev_agg.unit = inst.unit.clone();
171171
}
172172
_ => continue,

opentelemetry-sdk/src/trace/span_processor.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ use futures_util::{
4242
future::{self, BoxFuture, Either},
4343
select,
4444
stream::{self, FusedStream, FuturesUnordered},
45-
Stream, StreamExt as _,
45+
StreamExt as _,
4646
};
4747
use opentelemetry::global;
4848
use opentelemetry::{
@@ -399,7 +399,7 @@ impl<R: RuntimeChannel> BatchSpanProcessorInternal<R> {
399399
})
400400
}
401401

402-
async fn run(mut self, mut messages: impl Stream<Item = BatchMessage> + Unpin + FusedStream) {
402+
async fn run(mut self, mut messages: impl FusedStream<Item = BatchMessage> + Unpin) {
403403
loop {
404404
select! {
405405
// FuturesUnordered implements Fuse intelligently such that it

opentelemetry-zipkin/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
//! [`ZipkinPipelineBuilder`] docs for details of each option.
8585
//!
8686
//!
87-
//! ```no_run,ignore
87+
//! ```no_run
8888
//! use opentelemetry::{global, KeyValue, trace::Tracer};
8989
//! use opentelemetry_sdk::{trace::{self, RandomIdGenerator, Sampler}, Resource};
9090
//! use opentelemetry_sdk::export::trace::ExportResult;

0 commit comments

Comments
 (0)