Skip to content

Commit 401bfa5

Browse files
committed
fix comments
1 parent 7948912 commit 401bfa5

File tree

9 files changed

+2
-21
lines changed

9 files changed

+2
-21
lines changed

opentelemetry-sdk/benches/context.rs

-2
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,6 @@ impl SpanExporter for NoopExporter {
140140
fn export(&mut self, _spans: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
141141
Box::pin(futures_util::future::ready(Ok(())))
142142
}
143-
144-
fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
145143
}
146144

147145
#[cfg(not(target_os = "windows"))]

opentelemetry-sdk/benches/span_builder.rs

-2
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ impl SpanExporter for NoopExporter {
6868
fn export(&mut self, _spans: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
6969
Box::pin(futures_util::future::ready(Ok(())))
7070
}
71-
72-
fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
7371
}
7472

7573
const MAP_KEYS: [&str; 64] = [

opentelemetry-sdk/benches/trace.rs

-2
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ impl SpanExporter for VoidExporter {
6363
fn export(&mut self, _spans: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
6464
Box::pin(futures_util::future::ready(Ok(())))
6565
}
66-
67-
fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
6866
}
6967

7068
fn trace_benchmark_group<F: Fn(&sdktrace::Tracer)>(c: &mut Criterion, name: &str, f: F) {

opentelemetry-sdk/src/export/trace.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ pub trait SpanExporter: Send + Sync + Debug {
6565
}
6666

6767
/// Set the resource for the exporter.
68-
fn set_resource(&mut self, _resource: &Resource);
68+
fn set_resource(&mut self, _resource: &Resource) {}
6969
}
7070

7171
/// `SpanData` contains all the information collected by a `Span` and can be used

opentelemetry-sdk/src/testing/trace/span_exporters.rs

-5
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ impl SpanExporter for TokioSpanExporter {
6060
fn shutdown(&mut self) {
6161
self.tx_shutdown.send(()).unwrap();
6262
}
63-
64-
fn set_resource(&mut self, _resource: &crate::Resource) {}
6563
}
6664

6765
pub fn new_tokio_test_exporter() -> (
@@ -122,7 +120,4 @@ impl SpanExporter for NoopSpanExporter {
122120
fn export(&mut self, _: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
123121
Box::pin(std::future::ready(Ok(())))
124122
}
125-
126-
/// Set the resource for the exporter.
127-
fn set_resource(&mut self, _resource: &Resource) {}
128123
}

opentelemetry-sdk/src/trace/runtime_tests.rs

-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ impl SpanExporter for SpanCountExporter {
2929
self.span_count.fetch_add(batch.len(), Ordering::SeqCst);
3030
Box::pin(async { Ok(()) })
3131
}
32-
33-
fn set_resource(&mut self, _: &Resource) {}
3432
}
3533

3634
#[cfg(any(feature = "rt-tokio", feature = "rt-tokio-current-thread"))]

opentelemetry-sdk/src/trace/span_processor.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ pub trait SpanProcessor: Send + Sync + std::fmt::Debug {
9494
/// opportunity for processors to do any cleanup required.
9595
fn shutdown(&self) -> TraceResult<()>;
9696
/// Set the resource for the log processor.
97-
fn set_resource(&mut self, _resource: &Resource);
97+
fn set_resource(&mut self, _resource: &Resource) {}
9898
}
9999

100100
/// A [SpanProcessor] that passes finished spans to the configured
@@ -949,8 +949,6 @@ mod tests {
949949
use futures_util::FutureExt;
950950
Box::pin((self.delay_fn)(self.delay_for).map(|_| Ok(())))
951951
}
952-
953-
fn set_resource(&mut self, _resource: &Resource) {}
954952
}
955953

956954
#[test]

opentelemetry-zipkin/src/exporter/mod.rs

-2
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,6 @@ impl trace::SpanExporter for Exporter {
231231
self.local_endpoint.clone(),
232232
))
233233
}
234-
235-
fn set_resource(&mut self, _resource: &Resource) {}
236234
}
237235

238236
/// Wrap type for errors from opentelemetry zipkin

stress/src/traces.rs

-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ impl SpanProcessor for NoOpSpanProcessor {
4545
fn shutdown(&self) -> TraceResult<()> {
4646
Ok(())
4747
}
48-
49-
fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
5048
}
5149

5250
fn main() {

0 commit comments

Comments
 (0)