fix comments

Author: lalitb

opentelemetry-sdk/benches/context.rs

@@ -140,8 +140,6 @@ impl SpanExporter for NoopExporter {
     fn export(&mut self, _spans: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
         Box::pin(futures_util::future::ready(Ok(())))
     }
-
-    fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
 }
 
 #[cfg(not(target_os = "windows"))]

opentelemetry-sdk/benches/span_builder.rs

@@ -68,8 +68,6 @@ impl SpanExporter for NoopExporter {
     fn export(&mut self, _spans: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
         Box::pin(futures_util::future::ready(Ok(())))
     }
-
-    fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
 }
 
 const MAP_KEYS: [&str; 64] = [

opentelemetry-sdk/benches/trace.rs

@@ -63,8 +63,6 @@ impl SpanExporter for VoidExporter {
     fn export(&mut self, _spans: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
         Box::pin(futures_util::future::ready(Ok(())))
     }
-
-    fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
 }
 
 fn trace_benchmark_group<F: Fn(&sdktrace::Tracer)>(c: &mut Criterion, name: &str, f: F) {

opentelemetry-sdk/src/export/trace.rs

@@ -65,7 +65,7 @@ pub trait SpanExporter: Send + Sync + Debug {
     }
 
     /// Set the resource for the exporter.
-    fn set_resource(&mut self, _resource: &Resource);
+    fn set_resource(&mut self, _resource: &Resource) {}
 }
 
 /// `SpanData` contains all the information collected by a `Span` and can be used

opentelemetry-sdk/src/testing/trace/span_exporters.rs

@@ -60,8 +60,6 @@ impl SpanExporter for TokioSpanExporter {
     fn shutdown(&mut self) {
         self.tx_shutdown.send(()).unwrap();
     }
-
-    fn set_resource(&mut self, _resource: &crate::Resource) {}
 }
 
 pub fn new_tokio_test_exporter() -> (
@@ -122,7 +120,4 @@ impl SpanExporter for NoopSpanExporter {
     fn export(&mut self, _: Vec<SpanData>) -> BoxFuture<'static, ExportResult> {
         Box::pin(std::future::ready(Ok(())))
     }
-
-    /// Set the resource for the exporter.
-    fn set_resource(&mut self, _resource: &Resource) {}
 }

opentelemetry-sdk/src/trace/runtime_tests.rs

@@ -29,8 +29,6 @@ impl SpanExporter for SpanCountExporter {
         self.span_count.fetch_add(batch.len(), Ordering::SeqCst);
         Box::pin(async { Ok(()) })
     }
-
-    fn set_resource(&mut self, _: &Resource) {}
 }
 
 #[cfg(any(feature = "rt-tokio", feature = "rt-tokio-current-thread"))]

opentelemetry-sdk/src/trace/span_processor.rs

@@ -94,7 +94,7 @@ pub trait SpanProcessor: Send + Sync + std::fmt::Debug {
     /// opportunity for processors to do any cleanup required.
     fn shutdown(&self) -> TraceResult<()>;
     /// Set the resource for the log processor.
-    fn set_resource(&mut self, _resource: &Resource);
+    fn set_resource(&mut self, _resource: &Resource) {}
 }
 
 /// A [SpanProcessor] that passes finished spans to the configured
@@ -949,8 +949,6 @@ mod tests {
             use futures_util::FutureExt;
             Box::pin((self.delay_fn)(self.delay_for).map(|_| Ok(())))
         }
-
-        fn set_resource(&mut self, _resource: &Resource) {}
     }
 
     #[test]

opentelemetry-zipkin/src/exporter/mod.rs

@@ -231,8 +231,6 @@ impl trace::SpanExporter for Exporter {
             self.local_endpoint.clone(),
         ))
     }
-
-    fn set_resource(&mut self, _resource: &Resource) {}
 }
 
 /// Wrap type for errors from opentelemetry zipkin

stress/src/traces.rs

@@ -45,8 +45,6 @@ impl SpanProcessor for NoOpSpanProcessor {
     fn shutdown(&self) -> TraceResult<()> {
         Ok(())
     }
-
-    fn set_resource(&mut self, _resource: &opentelemetry_sdk::Resource) {}
 }
 
 fn main() {