Skip to content

Commit 29240d5

Browse files
committed
review comments
1 parent 2acff9e commit 29240d5

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

opentelemetry-sdk/src/trace/provider.rs

-4
Original file line numberDiff line numberDiff line change
@@ -272,10 +272,6 @@ mod tests {
272272
fn shutdown(&self) -> TraceResult<()> {
273273
self.force_flush()
274274
}
275-
276-
fn set_resource(&mut self, _: &Resource) {
277-
unimplemented!()
278-
}
279275
}
280276

281277
#[test]

opentelemetry-sdk/src/trace/span.rs

-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ impl Span {
7676
/// overhead.
7777
pub fn exported_data(&self) -> Option<crate::export::trace::SpanData> {
7878
let (span_context, tracer) = (self.span_context.clone(), &self.tracer);
79-
//let resource = self.tracer.provider()?.config().resource.clone();
8079

8180
self.data
8281
.as_ref()

opentelemetry-stdout/src/trace/exporter.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ impl SpanExporterBuilder {
117117
pub fn build(self) -> SpanExporter {
118118
SpanExporter {
119119
writer: Some(self.writer.unwrap_or_else(|| Box::new(stdout()))),
120-
resource: Resource::default(),
120+
resource: Resource::empty(),
121121
encoder: self.encoder.unwrap_or_else(|| {
122122
Box::new(|writer, spans| {
123123
serde_json::to_writer(writer, &spans)

0 commit comments

Comments
 (0)