review comments

Author: lalitb

opentelemetry-sdk/src/trace/provider.rs

@@ -272,10 +272,6 @@ mod tests {
         fn shutdown(&self) -> TraceResult<()> {
             self.force_flush()
         }
-
-        fn set_resource(&mut self, _: &Resource) {
-            unimplemented!()
-        }
     }
 
     #[test]

opentelemetry-sdk/src/trace/span.rs

@@ -76,7 +76,6 @@ impl Span {
     /// overhead.
     pub fn exported_data(&self) -> Option<crate::export::trace::SpanData> {
         let (span_context, tracer) = (self.span_context.clone(), &self.tracer);
-        //let resource = self.tracer.provider()?.config().resource.clone();
 
         self.data
             .as_ref()

opentelemetry-stdout/src/trace/exporter.rs

@@ -117,7 +117,7 @@ impl SpanExporterBuilder {
     pub fn build(self) -> SpanExporter {
         SpanExporter {
             writer: Some(self.writer.unwrap_or_else(|| Box::new(stdout()))),
-            resource: Resource::default(),
+            resource: Resource::empty(),
             encoder: self.encoder.unwrap_or_else(|| {
                 Box::new(|writer, spans| {
                     serde_json::to_writer(writer, &spans)