Skip to content

Commit 1119549

Browse files
authored
Remove async-trait crate as dependency for traces (#2339)
1 parent e6c351f commit 1119549

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

opentelemetry-sdk/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ pprof = { version = "0.13", features = ["flamegraph", "criterion"] }
4343

4444
[features]
4545
default = ["trace", "metrics", "logs", "internal-logs"]
46-
trace = ["opentelemetry/trace", "rand", "async-trait", "percent-encoding"]
46+
trace = ["opentelemetry/trace", "rand", "percent-encoding"]
4747
jaeger_remote_sampler = ["trace", "opentelemetry-http", "http", "serde", "serde_json", "url"]
4848
logs = ["opentelemetry/logs", "async-trait", "serde_json"]
4949
spec_unstable_logs_enabled = ["logs", "opentelemetry/spec_unstable_logs_enabled"]

opentelemetry-sdk/src/trace/span_processor.rs

-2
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,6 @@ mod tests {
727727
OTEL_BSP_MAX_CONCURRENT_EXPORTS_DEFAULT, OTEL_BSP_MAX_EXPORT_BATCH_SIZE_DEFAULT,
728728
};
729729
use crate::trace::{BatchConfig, BatchConfigBuilder, SpanEvents, SpanLinks};
730-
use async_trait::async_trait;
731730
use opentelemetry::trace::{SpanContext, SpanId, SpanKind, Status};
732731
use std::fmt::Debug;
733732
use std::future::Future;
@@ -963,7 +962,6 @@ mod tests {
963962
}
964963
}
965964

966-
#[async_trait]
967965
impl<D, DS> SpanExporter for BlockingExporter<D>
968966
where
969967
D: Fn(Duration) -> DS + 'static + Send + Sync,

0 commit comments

Comments
 (0)