Added a unittest with the feature configuration

Author: anujnegi270

opentelemetry-sdk/src/metrics/meter.rs

@@ -712,9 +712,7 @@ mod tests {
     };
 
     #[cfg(not(feature = "experimental_metrics_disable_name_validation"))]
-    use super::{
-        INSTRUMENT_NAME_EMPTY, INSTRUMENT_NAME_FIRST_ALPHABETIC, INSTRUMENT_NAME_INVALID_CHAR,
-    };
+    use super::{INSTRUMENT_NAME_FIRST_ALPHABETIC, INSTRUMENT_NAME_INVALID_CHAR};
 
     #[test]
     #[cfg(not(feature = "experimental_metrics_disable_name_validation"))]
@@ -733,6 +731,11 @@ mod tests {
             ("", INSTRUMENT_NAME_EMPTY),
             ("\\allow\\slash /sec", INSTRUMENT_NAME_FIRST_ALPHABETIC),
             ("\\allow\\$$slash /sec", INSTRUMENT_NAME_FIRST_ALPHABETIC),
+            ("Total $ Count", INSTRUMENT_NAME_INVALID_CHAR),
+            (
+                "\\test\\UsagePercent(Total) > 80%",
+                INSTRUMENT_NAME_FIRST_ALPHABETIC,
+            ),
             ("/not / allowed", INSTRUMENT_NAME_FIRST_ALPHABETIC),
         ];
         for (name, expected_error) in instrument_name_test_cases {
@@ -768,6 +771,8 @@ mod tests {
             ("", INSTRUMENT_NAME_EMPTY),
             ("\\allow\\slash /sec", ""),
             ("\\allow\\$$slash /sec", ""),
+            ("Total $ Count", ""),
+            ("\\test\\UsagePercent(Total) > 80%", ""),
             ("/not / allowed", ""),
         ];
         for (name, expected_error) in instrument_name_test_cases {

opentelemetry-sdk/src/metrics/mod.rs

@@ -132,15 +132,16 @@ mod tests {
     use std::time::Duration;
 
     // Run all tests in this mod
-    // cargo test metrics::tests --features=testing
+    // cargo test metrics::tests --features=testing,spec_unstable_metrics_views
     // Note for all tests from this point onwards in this mod:
     // "multi_thread" tokio flavor must be used else flush won't
     // be able to make progress!
 
     #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
+    #[cfg(not(feature = "experimental_metrics_disable_name_validation"))]
     async fn invalid_instrument_config_noops() {
         // Run this test with stdout enabled to see output.
-        // cargo test invalid_instrument_config_noops --features=testing -- --nocapture
+        // cargo test invalid_instrument_config_noops --features=testing,spec_unstable_metrics_views -- --nocapture
         let invalid_instrument_names = vec![
             "_startWithNoneAlphabet",
             "utf8char锈",
@@ -215,6 +216,66 @@ mod tests {
         }
     }
 
+    #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
+    #[cfg(feature = "experimental_metrics_disable_name_validation")]
+    async fn valid_instrument_config_noops_with_feature_experimental_metrics_disable_name_validation(
+    ) {
+        // Run this test with stdout enabled to see output.
+        // cargo test valid_instrument_config_noops_with_feature_experimental_metrics_disable_name_validation --features "testing,spec_unstable_metrics_views,experimental_metrics_disable_name_validation" -- --nocapture
+        let invalid_instrument_names = vec![
+            "_startWithNoneAlphabet",
+            "utf8char锈",
+            "\\allow\\slash /sec",
+            "\\allow\\$$slash /sec",
+            "Total $ Count",
+            "\\test\\UsagePercent(Total) > 80%",
+            "invalid name",
+        ];
+        for name in invalid_instrument_names {
+            let test_context = TestContext::new(Temporality::Cumulative);
+            let counter = test_context.meter().u64_counter(name).build();
+            counter.add(1, &[]);
+
+            let up_down_counter = test_context.meter().i64_up_down_counter(name).build();
+            up_down_counter.add(1, &[]);
+
+            let gauge = test_context.meter().f64_gauge(name).build();
+            gauge.record(1.9, &[]);
+
+            let histogram = test_context.meter().f64_histogram(name).build();
+            histogram.record(1.0, &[]);
+
+            let _observable_counter = test_context
+                .meter()
+                .u64_observable_counter(name)
+                .with_callback(move |observer| {
+                    observer.observe(1, &[]);
+                })
+                .build();
+
+            let _observable_gauge = test_context
+                .meter()
+                .f64_observable_gauge(name)
+                .with_callback(move |observer| {
+                    observer.observe(1.0, &[]);
+                })
+                .build();
+
+            let _observable_up_down_counter = test_context
+                .meter()
+                .i64_observable_up_down_counter(name)
+                .with_callback(move |observer| {
+                    observer.observe(1, &[]);
+                })
+                .build();
+
+            test_context.flush_metrics();
+
+            // As instrument name is invalid, no metrics should be exported
+            test_context.check_no_metrics();
+        }
+    }
+
     #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
     async fn counter_aggregation_delta() {
         // Run this test with stdout enabled to see output.
@@ -2495,6 +2556,10 @@ mod tests {
                 .get_finished_metrics()
                 .expect("metrics expected to be exported"); // TODO: Need to fix InMemoryMetricExporter to return None.
 
+            #[cfg(feature = "experimental_metrics_disable_name_validation")]
+            assert!(!resource_metrics.is_empty(), "metrics should be exported"); // TODO: Update this when enhanced feature flag is added.
+
+            #[cfg(not(feature = "experimental_metrics_disable_name_validation"))]
             assert!(resource_metrics.is_empty(), "no metrics should be exported");
         }