Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.js: Do not enable non-generic instrumentations by default #1735

Open
wpessers opened this issue Mar 6, 2025 · 0 comments · May be fixed by #1734
Open

node.js: Do not enable non-generic instrumentations by default #1735

wpessers opened this issue Mar 6, 2025 · 0 comments · May be fixed by #1734
Assignees
Labels
enhancement New feature or request

Comments

@wpessers
Copy link
Contributor

wpessers commented Mar 6, 2025

Currently the node.js instrumentation layer has a lot of default instrumentations. These default instrumentations are all being initialized when the OTEL_NODE_ENABLED_INSTRUMENTATIONS environment variable is not set. Meaning the wrapper will take longer to initialize due to a bunch of instrumentations being activated that most users probably don't even need.

An example: express, fastify, hapi and express instrumentations are all initialized by default. This does not make sense to me. Usually if people are using these sorts of frameworks they will stick to one. I also don't think we should be making the node instrumentation layer opinionated and that's why I would propose to remove all non-generic instrumentations from the defaults.

@wpessers wpessers added the enhancement New feature or request label Mar 6, 2025
@wpessers wpessers linked a pull request Mar 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant