chore: Remove metrics-port flag/usage from flagdproxy startup (#587)

Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>

Author: webstradev

common/flagdproxy/flagdproxy.go

@@ -120,7 +120,7 @@ func (f *FlagdProxyHandler) newFlagdProxyManifest(ownerReferences []metav1.Owner
 	replicas := int32(1)
 	args := []string{
 		"start",
-		"--metrics-port",
+		"--management-port",
 		fmt.Sprintf("%d", f.config.ManagementPort),
 	}
 	if f.config.DebugLogging {
@@ -165,7 +165,7 @@ func (f *FlagdProxyHandler) newFlagdProxyManifest(ownerReferences []metav1.Owner
 									ContainerPort: int32(f.config.Port),
 								},
 								{
-									Name:          "metrics-port",
+									Name:          "management-port",
 									ContainerPort: int32(f.config.ManagementPort),
 								},
 							},

common/flagdproxy/flagdproxy_test.go

@@ -208,7 +208,7 @@ func TestFlagdProxyHandler_HandleFlagdProxy_CreateProxy(t *testing.T) {
 	replicas := int32(1)
 	args := []string{
 		"start",
-		"--metrics-port",
+		"--management-port",
 		fmt.Sprintf("%d", 90),
 		"--debug",
 	}
@@ -256,7 +256,7 @@ func TestFlagdProxyHandler_HandleFlagdProxy_CreateProxy(t *testing.T) {
 									ContainerPort: int32(88),
 								},
 								{
-									Name:          "metrics-port",
+									Name:          "management-port",
 									ContainerPort: int32(90),
 								},
 							},