Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Add type feild to sync.SyncFlags payload. #1585

Open
1 task done
toddbaert opened this issue Mar 8, 2025 · 0 comments
Open
1 task done

[REFACTOR] Add type feild to sync.SyncFlags payload. #1585

toddbaert opened this issue Mar 8, 2025 · 0 comments

Comments

@toddbaert
Copy link
Member

toddbaert commented Mar 8, 2025

of course i can elaborate. Currently within the RPC mode we do have the EventStream, which will send on the inital connection a message provider_ready, and for upcoming messages configuration_change. This allows us within the RPC mode to be stateless. As flagd anyways knows when a configuration is established, or when it only informs about updates.

see https://buf.build/open-feature/flagd/docs/main:flagd.evaluation.v1#flagd.evaluation.v1.EventStreamResponse

this would allow us to unify the logic, and keep both modes stateless. Currently we need to know, if we have been connected or not as we need to know, if we need to fire a configuration change or provider ready event.

I hope i could shed some light here, and i hope my motivation regarding this unification is clear

Originally posted by @aepfli in #1584

Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant