Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Malleability] MockEntity #6680

Open
Tracked by #6646
UlyanaAndrukhiv opened this issue Nov 14, 2024 · 1 comment
Open
Tracked by #6646

[Malleability] MockEntity #6680

UlyanaAndrukhiv opened this issue Nov 14, 2024 · 1 comment

Comments

@UlyanaAndrukhiv
Copy link
Contributor

UlyanaAndrukhiv commented Nov 14, 2024 •
edited
Loading

Context

The current MockEntity type has the implementation of Entity on it. Review the MockEntity type to check that ID() method is being used and if so confirm that its ID() returns unique hash of all the content of MockEntity according to encoding rlp rules.

Definition of done

  1. Check usages of the ID() method.
  2. All structure fields are verified to be included in the hash.
  3. Make sure all tests work as expected.
@UlyanaAndrukhiv UlyanaAndrukhiv mentioned this issue Nov 14, 2024
Open
@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Feb 11, 2025
@UlyanaAndrukhiv UlyanaAndrukhiv changed the title [Malleability A] MockEntity [Malleability] MockEntity Feb 11, 2025
@UlyanaAndrukhiv UlyanaAndrukhiv mentioned this issue Feb 11, 2025
Open
@UlyanaAndrukhiv
Copy link
Contributor Author

Moved this issue to [EPIC] Refactor herocache/mempool package because MockEntity is used for tests for herocache/mempool.

@UlyanaAndrukhiv UlyanaAndrukhiv removed their assignment Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UlyanaAndrukhiv