Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Malleability] Fix ID misuse in disallowListCacheEntity type #6669

Open
Tracked by #6646
UlyanaAndrukhiv opened this issue Nov 14, 2024 · 1 comment
Open
Tracked by #6646

Comments

@UlyanaAndrukhiv
Copy link
Contributor

UlyanaAndrukhiv commented Nov 14, 2024

Context

Review the disallowListCacheEntity type to check that ID() method of the IDEntity interface is being used through the codebase and if so confirm that its ID() hashes all fields to meet new requirements.

Definition of done

  • Check the usage of ID().
  • All structure fields are verified to be included in the hash.
  • Make sure all tests work as expected.
@AndriiDiachuk
Copy link
Contributor

AndriiDiachuk commented Feb 11, 2025

Moved this issue to [EPIC] Refactor herocache/mempool package because disallowListCacheEntity is internally used by the cache and misused ID() to be compatible with herocache.

@AndriiDiachuk AndriiDiachuk changed the title [Malleability A] disallowListCacheEntity [Malleability] Fix ID misuse in disallowListCacheEntity type Feb 11, 2025
@AndriiDiachuk AndriiDiachuk removed their assignment Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants