Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Malleability] AssignmentDataPack #6664

Open
Tracked by #6646
UlyanaAndrukhiv opened this issue Nov 14, 2024 · 1 comment
Open
Tracked by #6646

[Malleability] AssignmentDataPack #6664

UlyanaAndrukhiv opened this issue Nov 14, 2024 · 1 comment
Assignees
@illia-malachyn

Comments

@UlyanaAndrukhiv
Copy link
Contributor

UlyanaAndrukhiv commented Nov 14, 2024 •
edited by illia-malachyn
Loading

Both ID() and Checksum don't hash all fields. Fix this
@UlyanaAndrukhiv UlyanaAndrukhiv mentioned this issue Nov 14, 2024
Open
@illia-malachyn illia-malachyn self-assigned this Jan 17, 2025
@illia-malachyn
Copy link
Contributor

This type implements Entity only to be able to put in herocache. It is a misuse.
Solution: The type should not implement Entity. It should implement herocache specific interface.
I'm moving it to the herocache epic #6646

@illia-malachyn illia-malachyn mentioned this issue Jan 17, 2025
Open
@illia-malachyn illia-malachyn changed the title [Malleability A] AssignmentDataPack [Malleability] AssignmentDataPack Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-malachyn illia-malachyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@UlyanaAndrukhiv @illia-malachyn