Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: dry run deployment script #97

Merged
merged 25 commits into from
Jul 14, 2024
Merged

ci: dry run deployment script #97

merged 25 commits into from
Jul 14, 2024

Conversation

gosuto-inzasheru
Copy link
Contributor

closes #95

@codecov Codecov
Copy link

codecov bot commented Jul 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (4b5d50c) to head (d9a631d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   97.07%   99.02%   +1.95%     
==========================================
  Files           2        2              
  Lines         205      205              
  Branches       33       33              
==========================================
+ Hits          199      203       +4     
  Misses          2        2              
+ Partials        4        0       -4

see 2 files with indirect coverage changes

@gosuto-inzasheru
Copy link
Contributor Author

i used the outdated actions/setup-node@v3 on purpose, to verify dependabot will successfully attempt to bump it to @v4

yarn cache is successfully saved at the end:

Post job cleanup.
/usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/robosaver/robosaver --files-from manifest.txt --use-compress-program zstdmt
Cache Size: ~110 MB (114847701 B)
Cache saved successfully
Cache saved with the key: node-cache-Linux-yarn-70ef04d488dc4cdde1[2](https://github.com/onchainification/robosaver/actions/runs/9919181788/job/27404734374?pr=97#step:10:2)d235ce84557517dcfd51bdd93ce03ce5b07ae84048ded

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review July 13, 2024 10:19
@gosuto-inzasheru
Copy link
Contributor Author

i cant figure out why the first commit is responsible for changes in the codecov report: https://app.codecov.io/gh/onchainification/robosaver/commit/43fe21f1f8894d6a0dd276b1f4b6ac647e7c4a01/indirect-changes

@gosuto-inzasheru gosuto-inzasheru marked this pull request as draft July 13, 2024 11:40
@gosuto-inzasheru
Copy link
Contributor Author

it actually matches the summary i get locally:

Ran 9 test suites in 33.42s (209.01s CPU time): 24 tests passed, 0 failed, 0 skipped (24 total tests)
| File                                  | % Lines          | % Statements     | % Branches     | % Funcs         |
|---------------------------------------|------------------|------------------|----------------|-----------------|
| src/RoboSaverVirtualModule.sol        | 99.44% (179/180) | 99.63% (271/272) | 95.00% (57/60) | 100.00% (26/26) |
| src/RoboSaverVirtualModuleFactory.sol | 95.83% (23/24)   | 94.44% (34/36)   | 83.33% (5/6)   | 80.00% (4/5)    |
| Total                                 | 99.02% (202/204) | 99.03% (305/308) | 93.94% (62/66) | 96.77% (30/31)  |

not sure what is going on, some partials are now considered fully covered all of the sudden

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review July 13, 2024 12:50
@gosuto-inzasheru
Copy link
Contributor Author

it is however not related to this pr; i get the same coverage summary on the main branch

we should investigate more but indifferent of this pr

@gosuto-inzasheru
Copy link
Contributor Author

ok i think i figured it out, @petrovska-petro you once pushed to main and i think those changed were thus never covered by codecov. somehow now they are, hence the delta in coverage in this pr

this pr will therefor also close #79 and #81

im not yet convinced of #80 (ref: https://app.codecov.io/gh/onchainification/robosaver/pull/97/indirect-changes#6e61a7efb13d1515664c616960f618f8-L109)

This was linked to issues Jul 13, 2024
test: cover _isCleanQueueRequired #79
Closed
test: cover LINK.approve in the factory constructor #81
Open
petrovska-petro
petrovska-petro approved these changes Jul 14, 2024
View reviewed changes
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice having on ci as well the whole dry flow of the scripts and make sure runs w/o hiccups ✅

great to see the addition of our old friend dependabot 🤖

@gosuto-inzasheru gosuto-inzasheru merged commit 2f18528 into main Jul 14, 2024
3 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the issue/95 branch July 14, 2024 06:21
@petrovska-petro
Copy link
Collaborator

im not yet convinced of #80 (ref: https://app.codecov.io/gh/onchainification/robosaver/pull/97/indirect-changes#6e61a7efb13d1515664c616960f618f8-L109)

this is weird actually, nothing changed on this pr that hits more on that specific line 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrovska-petro petrovska-petro petrovska-petro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gosuto-inzasheru @petrovska-petro