-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chores: reorg events into its own interface file #105
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a common approach?
why not do the same as the errors, and have an libraries/Events.sol
?
im confused because the interface file this now creates does not actually provide a full interface to the vmodule (or factory), and is thus unusable for an external project trying to use those interface files for example
it is used in some of the codebases that i personally find the cleanest; file organisation wise. but it is a way of many missed pushing before the methods before as it creates errs that i need to look further, but i agree that generally the should include the methods as well so they're reusable then, we could use as well |
it could be perfectly an on the side of verification things, im not sure how it may affect tbh, smth to try out, but i imagine should not present a problem |
closes #77