Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: renaming of vars and improved comments #14

Merged
merged 12 commits into from
May 9, 2024
Merged

docs: renaming of vars and improved comments #14

merged 12 commits into from
May 9, 2024

Conversation

gosuto-inzasheru
Copy link
Contributor

closes #10

@gosuto-inzasheru
Copy link
Contributor Author

gosuto-inzasheru commented May 9, 2024 •
edited
Loading

draft of the diagram for now:

Screenshot 2024-05-09 at 10 12 22

@gosuto-inzasheru gosuto-inzasheru changed the base branch from main to feat/unify-method-gelato May 9, 2024 06:45
@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review May 9, 2024 06:46
petrovska-petro
petrovska-petro approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lang clean-up, i like the readability of adjustPool and the concept of deficit/surplus. good one ✅

@petrovska-petro petrovska-petro merged commit 56dced5 into feat/unify-method-gelato May 9, 2024
1 check failed
@petrovska-petro petrovska-petro deleted the issue/10 branch May 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrovska-petro petrovska-petro petrovska-petro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: var/comment renaming
2 participants
@gosuto-inzasheru @petrovska-petro