-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test driver for integration tests and examples #765
Comments
I think more concrete requirements are needed. What are the conditions that require a re-build/re-install of the test code? What is the agreed-upon filesystem layout so that a test runner can effectively locate code to run? I am 👎 on extending the either Offhand I would suggest that building and installing could be the purview of |
I would similarly agree that the build/install of of the testing code is separate from the execution of the testing code. I would be hesitant about adding it to @magnatelee to comment |
I agree you all that building of integration tests should be separate from running them, preferably triggered by a script other than install.py. Also note that we've been building integration tests in the core's cmake build by default, so we may have had been accidentally including shared libraries from the tests in the package, which gives us another reason to completely separate the build of integration tests. Here's the structure I suggest: (1) a CI job for the build creates a Docker image for downstream CI jobs. The image has a conda environment where legate core is installed. |
Just noting that as of this week the driver can execute binary legate executables directly, in addition to running python scripts with |
We've recently added some integration tests and examples for legate core, but they are not being correctly hooked up with CI, nor do we have a driver to run them all. It'd be nice if we could extend legate.driver to handle those. A tricky part is that they are libraries themselves and they each involve an installation step, which is a substantially different model from what legate.driver was originally designed to handle. I'll let @bryevdv figure out the right way to extend legate.driver and once that's done either @sandeepd-nv or @m3vaz can update the CI script to include those new tests.
cc @jjwilke, as he worked on his own framework to express multi-step workflows, which we might want to consider using for the extension.
The text was updated successfully, but these errors were encountered: