tests: [torrust#1251] add test for loading keys in DB drivers

Author: josecelano

packages/tracker-core/src/authentication/key/mod.rs

@@ -67,6 +67,12 @@ pub fn generate_permanent_key() -> PeerKey {
     generate_key(None)
 }
 
+/// It generates a new expiring random key [`PeerKey`].
+#[must_use]
+pub fn generate_expiring_key(lifetime: Duration) -> PeerKey {
+    generate_key(Some(lifetime))
+}
+
 /// It generates a new random 32-char authentication [`PeerKey`].
 ///
 /// It can be an expiring or permanent key.

packages/tracker-core/src/databases/driver/mod.rs

@@ -104,6 +104,8 @@ mod tests {
 
         // Authentication keys (for private trackers)
 
+        handling_authentication_keys::it_should_load_the_keys(driver);
+
         // Permanent keys
         handling_authentication_keys::it_should_save_and_load_permanent_authentication_keys(driver);
         handling_authentication_keys::it_should_remove_a_permanent_authentication_key(driver);
@@ -114,10 +116,10 @@ mod tests {
 
         // Whitelist (for listed trackers)
 
+        handling_the_whitelist::it_should_load_the_whitelist(driver);
         handling_the_whitelist::it_should_add_and_get_infohashes(driver);
         handling_the_whitelist::it_should_remove_an_infohash_from_the_whitelist(driver);
         handling_the_whitelist::it_should_fail_trying_to_add_the_same_infohash_twice(driver);
-        handling_the_whitelist::it_load_the_whitelist(driver);
     }
 
     /// It initializes the database schema.
@@ -172,9 +174,22 @@ mod tests {
         use std::sync::Arc;
         use std::time::Duration;
 
-        use crate::authentication::key::{generate_key, generate_permanent_key};
+        use crate::authentication::key::{generate_expiring_key, generate_permanent_key};
         use crate::databases::Database;
 
+        pub fn it_should_load_the_keys(driver: &Arc<Box<dyn Database>>) {
+            let permanent_peer_key = generate_permanent_key();
+            driver.add_key_to_keys(&permanent_peer_key).unwrap();
+
+            let expiring_peer_key = generate_expiring_key(Duration::from_secs(120));
+            driver.add_key_to_keys(&expiring_peer_key).unwrap();
+
+            let keys = driver.load_keys().unwrap();
+
+            assert!(keys.contains(&permanent_peer_key));
+            assert!(keys.contains(&expiring_peer_key));
+        }
+
         pub fn it_should_save_and_load_permanent_authentication_keys(driver: &Arc<Box<dyn Database>>) {
             let peer_key = generate_permanent_key();
             driver.add_key_to_keys(&peer_key).unwrap();
@@ -185,7 +200,7 @@ mod tests {
         }
 
         pub fn it_should_save_and_load_expiring_authentication_keys(driver: &Arc<Box<dyn Database>>) {
-            let peer_key = generate_key(Some(Duration::from_secs(120)));
+            let peer_key = generate_expiring_key(Duration::from_secs(120));
             driver.add_key_to_keys(&peer_key).unwrap();
 
             let stored_peer_key = driver.get_key_from_keys(&peer_key.key()).unwrap().unwrap();
@@ -204,7 +219,7 @@ mod tests {
         }
 
         pub fn it_should_remove_an_expiring_authentication_key(driver: &Arc<Box<dyn Database>>) {
-            let peer_key = generate_key(Some(Duration::from_secs(120)));
+            let peer_key = generate_expiring_key(Duration::from_secs(120));
             driver.add_key_to_keys(&peer_key).unwrap();
 
             driver.remove_key_from_keys(&peer_key.key()).unwrap();
@@ -220,6 +235,15 @@ mod tests {
         use crate::core_tests::random_info_hash;
         use crate::databases::Database;
 
+        pub fn it_should_load_the_whitelist(driver: &Arc<Box<dyn Database>>) {
+            let infohash = random_info_hash();
+            driver.add_info_hash_to_whitelist(infohash).unwrap();
+
+            let whitelist = driver.load_whitelist().unwrap();
+
+            assert!(whitelist.contains(&infohash));
+        }
+
         pub fn it_should_add_and_get_infohashes(driver: &Arc<Box<dyn Database>>) {
             let infohash = random_info_hash();
 
@@ -247,14 +271,5 @@ mod tests {
 
             assert!(result.is_err());
         }
-
-        pub fn it_load_the_whitelist(driver: &Arc<Box<dyn Database>>) {
-            let infohash = random_info_hash();
-            driver.add_info_hash_to_whitelist(infohash).unwrap();
-
-            let whitelist = driver.load_whitelist().unwrap();
-
-            assert!(whitelist.contains(&infohash));
-        }
     }
 }