Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a valgrind check to GitHub CI #93

Open
thilinarmtb opened this issue Nov 6, 2022 · 2 comments
Open

Add a valgrind check to GitHub CI #93

thilinarmtb opened this issue Nov 6, 2022 · 2 comments
Assignees
@HirumalPriyashan
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thilinarmtb
Copy link
Contributor

Following can be used as a starting point:
https://iramykytyn.dev/how-to-integrate-valgrind-into-github-actions
@thilinarmtb thilinarmtb added the good first issue Good for newcomers label Nov 6, 2022
@thilinarmtb
Copy link
Contributor Author

Seems like valgrind test (and other tests) can be integrated to cmake itself:
https://github.com/ainfosec/ci_helloworld

That will enable the developer to perform this tests locally as well.

@thilinarmtb thilinarmtb added the enhancement New feature or request label Nov 6, 2022
@thilinarmtb thilinarmtb changed the title Add a valgrind check to github ci Add a valgrind check to GitHub CI Nov 6, 2022
@HirumalPriyashan HirumalPriyashan self-assigned this Nov 10, 2022
@thilinarmtb
Copy link
Contributor Author

thilinarmtb commented Nov 10, 2022 •
edited
Loading

Valgrind suppression file for CPython: https://github.com/python/cpython/blob/main/Misc/valgrind-python.supp

Suppression file basically filter out false positive errors. We need this because we use CPython to call Python from C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HirumalPriyashan HirumalPriyashan

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thilinarmtb @HirumalPriyashan