Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: add support for intermediate certs in --use-system-ca #57164

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

crypto: add support for intermediate certs in --use-system-ca #57164

wants to merge 4 commits into from
+222 −13

Conversation

timja
Copy link
Contributor

@timja timja commented Feb 21, 2025 •
edited
Loading

Fixes #57163

TODO:

  • Extend existing test to validate intermediate certificates
  • Validate that removing the root cert means intermediate isn't trusted - Works fine

Run new test on:

  • macOS
  • Windows
  • Linux

I've tested locally and this is working fine

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Feb 21, 2025
@timja timja mentioned this pull request Feb 21, 2025
Open
@timja timja force-pushed the intermediate-certificates branch from 6250353 to 5624123 Compare February 21, 2025 22:30
@timja timja force-pushed the intermediate-certificates branch from 5624123 to e6d4cc0 Compare February 21, 2025 22:34
@timja timja mentioned this pull request Feb 22, 2025
Open
1 task
@timja timja marked this pull request as ready for review February 22, 2025 10:53
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (772c609) to head (c3b8c05).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57164      +/-   ##
==========================================
- Coverage   90.36%   90.35%   -0.01%     
==========================================
  Files         629      629              
  Lines      184308   184373      +65     
  Branches    36010    36025      +15     
==========================================
+ Hits       166544   166594      +50     
+ Misses      10910    10907       -3     
- Partials     6854     6872      +18
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 65.09% <ø> (ø)

... and 31 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--use-system-ca support for intermediate certificates on Windows
2 participants
@timja @nodejs-github-bot