Skip to content

Commit 47aa2b5

Browse files
karteekmurthysfacebook-github-bot
authored andcommitted
Add new stats to to track decompression and compression times (facebookincubator#12593)
Summary: Pull Request resolved: facebookincubator#12593 For internal tests we are tracking the compression times within the table writer. Reviewed By: Yuhta Differential Revision: D70910856 fbshipit-source-id: 919be1b9914d1dc77248f36490f6c49cbddf133d
1 parent 89afec8 commit 47aa2b5

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

velox/connectors/Connector.h

+4
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,10 @@ class DataSink {
190190
uint64_t numWrittenBytes{0};
191191
uint32_t numWrittenFiles{0};
192192
uint64_t writeIOTimeUs{0};
193+
uint64_t numCompressedBytes{0};
194+
uint64_t wallRecodeTimeNs{0};
195+
uint64_t compressionTimeNs{0};
196+
193197
common::SpillStats spillStats;
194198

195199
bool empty() const;

velox/exec/TableWriter.cpp

+11
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,17 @@ void TableWriter::updateStats(const connector::DataSink::Stats& stats) {
293293
"writeIOTime",
294294
RuntimeCounter(
295295
stats.writeIOTimeUs * 1000, RuntimeCounter::Unit::kNanos));
296+
if (stats.wallRecodeTimeNs != 0) {
297+
lockedStats->addRuntimeStat(
298+
"wallRecodeTime",
299+
RuntimeCounter(stats.wallRecodeTimeNs, RuntimeCounter::Unit::kNanos));
300+
}
301+
if (stats.compressionTimeNs != 0) {
302+
lockedStats->addRuntimeStat(
303+
"compressionTime",
304+
RuntimeCounter(
305+
stats.compressionTimeNs, RuntimeCounter::Unit::kNanos));
306+
}
296307
}
297308
if (!stats.spillStats.empty()) {
298309
*spillStats_.wlock() += stats.spillStats;

0 commit comments

Comments
 (0)