Skip to content

Commit 0cd6c0a

Browse files
kagamiorifacebook-github-bot
authored andcommitted
Update skip function list of AggregationFuzzerTest and WindowFuzzerTest (facebookincubator#9138)
Summary: Pull Request resolved: facebookincubator#9138 Update the skip function list of AggregationFuzzerTest and WindowFuzzerTest so that they can successfully run for 1 hour. This is needed for setting up nightly job of the fuzzer tests. Functions in the skip function list will be removed once they are unblocked later. Reviewed By: kgpai Differential Revision: D55026943 fbshipit-source-id: 31d90ded24f566ff528d8dd710cd6805ceccfc9a
1 parent ac7f58f commit 0cd6c0a

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ int main(int argc, char** argv) {
102102

103103
// List of functions that have known bugs that cause crashes or failures.
104104
static const std::unordered_set<std::string> skipFunctions = {
105+
// Skip internal functions used only for result verifications.
106+
"$internal$count_distinct",
105107
// https://github.com/facebookincubator/velox/issues/3493
106108
"stddev_pop",
107109
// Lambda functions are not supported yet.
@@ -111,7 +113,8 @@ int main(int argc, char** argv) {
111113
"approx_set",
112114
"min_by",
113115
"max_by",
114-
"any_value"};
116+
"any_value",
117+
};
115118

116119
using facebook::velox::exec::test::ApproxDistinctResultVerifier;
117120
using facebook::velox::exec::test::ApproxPercentileResultVerifier;

velox/functions/prestosql/fuzzer/WindowFuzzerTest.cpp

+9-3
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ getCustomInputGenerators() {
7070

7171
int main(int argc, char** argv) {
7272
facebook::velox::aggregate::prestosql::registerAllAggregateFunctions(
73-
"", false);
73+
"", false, true);
7474
facebook::velox::aggregate::prestosql::registerInternalAggregateFunctions("");
7575
facebook::velox::window::prestosql::registerAllWindowFunctions();
7676
facebook::velox::functions::prestosql::registerAllScalarFunctions();
@@ -87,12 +87,18 @@ int main(int argc, char** argv) {
8787

8888
// List of functions that have known bugs that cause crashes or failures.
8989
static const std::unordered_set<std::string> skipFunctions = {
90+
// Skip internal functions used only for result verifications.
91+
"$internal$count_distinct",
9092
// https://github.com/facebookincubator/velox/issues/3493
9193
"stddev_pop",
9294
// Lambda functions are not supported yet.
9395
"reduce_agg",
94-
// Skip internal functions used only for result verifications.
95-
"$internal$count_distinct",
96+
// array_agg requires a flag controlling whether to ignore nulls.
97+
"array_agg",
98+
// min_by and max_by are fixed recently, requiring Presto-0.286.
99+
// https://github.com/prestodb/presto/pull/21793
100+
"min_by",
101+
"max_by",
96102
};
97103

98104
// Functions whose results verification should be skipped. These can be

0 commit comments

Comments
 (0)