Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DhcpV4Client trait for async and blocking client #17

Closed
Jackbaude opened this issue Feb 18, 2023 · 1 comment · Fixed by #45
Closed

DhcpV4Client trait for async and blocking client #17

Jackbaude opened this issue Feb 18, 2023 · 1 comment · Fixed by #45

Comments

@Jackbaude
Copy link

The DhcpV4ClientAsync does not implement the same methods as DhcpV4Client. It would be helpful to have methods such as release_lease on the async version. Is there a way to call these methods on DhcpV4Client or would this be helpful to additionally have these methods on DhcpV4ClientAsync. I would be willing to do this if that is the case.

@cathay4t
Copy link
Contributor

The underneath implementation is just send out a UDP package and no reply required from DHCP server.

So you may just create a async function to DhcpV4ClientAsync without any async stuff in it just to be consistent with DhcpV4Client.

I have to admit, this project is crated before rust async become stable, so the fundamental code is not async-aware.

@cathay4t cathay4t linked a pull request Dec 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants