Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate the CheckoutRequest type #372

Open
4 tasks
nibhar opened this issue Jan 14, 2020 · 0 comments
Open
4 tasks

Iterate the CheckoutRequest type #372

nibhar opened this issue Jan 14, 2020 · 0 comments

Comments

@nibhar
Copy link
Member

nibhar commented Jan 14, 2020 •
edited
Loading

The CheckoutRequest has some open questions:

  • change shopLogoUrl to i.e. appLogoUrl
  • are protocolSpecifics needed or can this be flattened into the paymentOption.
  • amount or value for the to-be-paid amount in the smallest unit.
  • move extraData from the base level of the request into the NimiqPaymentOptions

Also potentially the typing of the ParsedCheckoutRequest could be improved regarding versions 1 and 2.

To be done after a consolidated branch for the MultiCurrencyCheckout is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nibhar