[FIX] Fix access right issues when using actions

sebalix · sebalix · commit d29e26e6c196 · 2022-01-31T11:49:35.000+01:00
diff --git a/account_invoice_download/models/account_invoice_download_config.py b/account_invoice_download/models/account_invoice_download_config.py
@@ -160,9 +160,8 @@ def run_button(self):
             credentials = self.prepare_credentials()
             invoice_ids, log_id = self.run(credentials)
             if invoice_ids:
-                action = (
-                    self.env.ref("account.action_move_in_invoice_type").sudo().read()[0]
-                )
+                xmlid = "account.action_move_in_invoice_type"
+                action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
                 action.update(
                     {
                         "views": False,
@@ -171,13 +170,8 @@ def run_button(self):
                     }
                 )
             else:
-                action = (
-                    self.env.ref(
-                        "account_invoice_download.account_invoice_download_log_action"
-                    )
-                    .sudo()
-                    .read()[0]
-                )
+                xmlid = "account_invoice_download.account_invoice_download_log_action"
+                action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
                 action.update(
                     {
                         "res_id": log_id,
@@ -187,12 +181,11 @@ def run_button(self):
                 )
             return action
         else:
-            credentials_wiz_action = (
-                self.env.ref(
-                    "account_invoice_download.account_invoice_download_credentials_action"
-                )
-                .sudo()
-                .read()[0]
+            xmlid = (
+                "account_invoice_download.account_invoice_download_credentials_action"
+            )
+            credentials_wiz_action = self.env["ir.actions.act_window"]._for_xml_id(
+                xmlid
             )
             return credentials_wiz_action
 
diff --git a/account_invoice_download/wizard/account_invoice_download_credentials.py b/account_invoice_download/wizard/account_invoice_download_credentials.py
@@ -76,9 +76,8 @@ def run(self):
         """The real work is made in create(), not here!"""
         self.ensure_one()
         if self.invoice_ids_str:
-            action = (
-                self.env.ref("account.action_move_in_invoice_type").sudo().read()[0]
-            )
+            xmlid = "account.action_move_in_invoice_type"
+            action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
             action.update(
                 {
                     "views": False,
@@ -87,13 +86,8 @@ def run(self):
                 }
             )
         else:
-            action = (
-                self.env.ref(
-                    "account_invoice_download.account_invoice_download_log_action"
-                )
-                .sudo()
-                .read()[0]
-            )
+            xmlid = "account_invoice_download.account_invoice_download_log_action"
+            action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
             action.update(
                 {
                     "res_id": self.log_id.id,
diff --git a/account_invoice_download_ovh/wizard/ovh_api_credentials.py b/account_invoice_download_ovh/wizard/ovh_api_credentials.py
@@ -63,11 +63,8 @@ def default_get(self, fields_list):
 
     def action_continue_wizard(self):
         self.ensure_one()
-        action = (
-            self.env.ref("account_invoice_download_ovh.ovh_api_credentials_action")
-            .sudo()
-            .read()[0]
-        )
+        xmlid = "account_invoice_download_ovh.ovh_api_credentials_action"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["res_id"] = self.id
         return action
 
diff --git a/account_invoice_import/models/res_partner.py b/account_invoice_import/models/res_partner.py
@@ -34,11 +34,8 @@ def _compute_invoice_import_count(self):
 
     def show_account_invoice_import_config(self):
         self.ensure_one()
-        action = (
-            self.env.ref("account_invoice_import.account_invoice_import_config_action")
-            .sudo()
-            .read()[0]
-        )
+        xmlid = "account_invoice_import.account_invoice_import_config_action"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["context"] = {
             "default_name": self.name,
             "default_partner_id": self.id,
diff --git a/account_invoice_import/wizard/account_invoice_import.py b/account_invoice_import/wizard/account_invoice_import.py
@@ -561,11 +561,8 @@ def goto_partner_not_found(self, parsed_inv, error_message):
             if country:
                 vals["partner_country_id"] = country.id
         self.write(vals)
-        action = (
-            self.env.ref("account_invoice_import.account_invoice_import_action")
-            .sudo()
-            .read()[0]
-        )
+        xmlid = "account_invoice_import.account_invoice_import_action"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["res_id"] = self.id
         return action
 
@@ -747,11 +744,8 @@ def import_invoice(self):
 
         if not wiz_vals.get("import_config_id"):
             wiz_vals["state"] = "config"
-            action = (
-                self.env.ref("account_invoice_import.account_invoice_import_action")
-                .sudo()
-                .read()[0]
-            )
+            xmlid = "account_invoice_import.account_invoice_import_action"
+            action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
             action["res_id"] = self.id
         else:
             draft_same_supplier_invs = amo.search(
@@ -766,11 +760,8 @@ def import_invoice(self):
                 wiz_vals["state"] = "update"
                 if len(draft_same_supplier_invs) == 1:
                     wiz_vals["invoice_id"] = draft_same_supplier_invs[0].id
-                action = (
-                    self.env.ref("account_invoice_import.account_invoice_import_action")
-                    .sudo()
-                    .read()[0]
-                )
+                xmlid = "account_invoice_import.account_invoice_import_action"
+                action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
                 action["res_id"] = self.id
             else:
                 action = self.create_invoice_action(
@@ -793,7 +784,8 @@ def create_invoice_action(self, parsed_inv=None, import_config=None, origin=None
             assert self.import_config_id
             import_config = self.import_config_id.convert_to_import_config()
         invoice = self.create_invoice(parsed_inv, import_config, origin)
-        action = self.env.ref("account.action_move_in_invoice_type").sudo().read()[0]
+        xmlid = "account.action_move_in_invoice_type"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action.update(
             {
                 "view_mode": "form,tree,kanban",
@@ -1271,7 +1263,8 @@ def update_invoice(self):
             )
             % self.invoice_filename
         )
-        action = self.env.ref("account.action_move_in_invoice_type").sudo().read()[0]
+        xmlid = "account.action_move_in_invoice_type"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action.update(
             {
                 "view_mode": "form,tree,kanban",
diff --git a/edi_backend_partner_oca/models/res_partner.py b/edi_backend_partner_oca/models/res_partner.py
@@ -18,13 +18,13 @@ def _compute_edi_backend_count(self):
             rec.edi_backend_count = len(rec.edi_backend_ids)
 
     def action_edi_backend(self):
-        action = self.env.ref("edi_oca.act_open_edi_backend_view")
-        result = action.read()[0]
+        xmlid = "edi_oca.act_open_edi_backend_view"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         backends = self.mapped("edi_backend_ids")
         if len(backends) > 1:
-            result["domain"] = [("id", "in", backends.ids)]
+            action["domain"] = [("id", "in", backends.ids)]
         else:
             res = self.env.ref("edi_oca.edi_backend_view_form", False)
-            result["views"] = [(res and res.id or False, "form")]
-            result["res_id"] = backends.id
-        return result
+            action["views"] = [(res and res.id or False, "form")]
+            action["res_id"] = backends.id
+        return action
diff --git a/edi_endpoint_oca/models/edi_backend.py b/edi_endpoint_oca/models/edi_backend.py
@@ -22,7 +22,8 @@ def _compute_endpoints_count(self):
             record.endpoints_count = len(record.endpoint_ids)
 
     def action_manage_endpoints(self):
-        action = self.env.ref("edi_endpoint_oca.edi_endpoint_act_window").read()[0]
+        xmlid = "edi_endpoint_oca.edi_endpoint_act_window"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["domain"] = [
             ("backend_type_id", "=", self.backend_type_id.id),
             "|",
diff --git a/edi_oca/models/edi_exchange_consumer_mixin.py b/edi_oca/models/edi_exchange_consumer_mixin.py
@@ -133,7 +133,8 @@ def edi_create_exchange_record(self, exchange_type_id):
             )
         if backend:
             return self._edi_create_exchange_record(exchange_type, backend)
-        action = self.env.ref("edi_oca.edi_exchange_record_create_act_window").read()[0]
+        xmlid = "edi_oca.edi_exchange_record_create_act_window"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["context"] = {
             "default_res_id": self.id,
             "default_model": self._name,
@@ -183,7 +184,8 @@ def _compute_exchange_record_count(self):
 
     def action_view_edi_records(self):
         self.ensure_one()
-        action = self.env.ref("edi_oca.act_open_edi_exchange_record_view").read()[0]
+        xmlid = "edi_oca.act_open_edi_exchange_record_view"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["domain"] = [("model", "=", self._name), ("res_id", "=", self.id)]
         return action
 
diff --git a/edi_oca/models/edi_exchange_record.py b/edi_oca/models/edi_exchange_record.py
@@ -290,7 +290,8 @@ def action_open_related_exchanges(self):
         self.ensure_one()
         if not self.related_exchange_ids:
             return {}
-        action = self.env.ref("edi_oca.act_open_edi_exchange_record_view").read()[0]
+        xmlid = "edi_oca.act_open_edi_exchange_record_view"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["domain"] = [("id", "in", self.related_exchange_ids.ids)]
         return action
 
diff --git a/endpoint_auth_api_key/models/endpoint_mixin.py b/endpoint_auth_api_key/models/endpoint_mixin.py
@@ -34,8 +34,7 @@ def _allowed_api_key_ids(self):
         return self.auth_api_key_group_ids.auth_api_key_ids.ids
 
     def action_view_api_key_groups(self):
-        action = self.env.ref(
-            "auth_api_key_group.auth_api_key_group_act_window"
-        ).read()[0]
+        xmlid = "auth_api_key_group.auth_api_key_group_act_window"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
         action["domain"] = [("id", "in", self.auth_api_key_group_ids.ids)]
         return action
