Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGSTACK-794 add check if tags field is actually required before valid… #166

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

RobertK0
Copy link
Contributor

SELECTOR_FIELD was defined with required class, now it has been removed to be more in line with ibexa's way of selecting elements, where required class is checked inside the actual validator function.

This was also breaking selection of the label element, because not all tag container elements have required class on them

@RobertK0 RobertK0 requested a review from emodric February 14, 2025 13:17
@emodric emodric merged commit 6713bb0 into master Feb 14, 2025
5 checks passed
@emodric emodric deleted the NGSTACK-794-validation branch February 14, 2025 13:47
@emodric
Copy link
Member

emodric commented Feb 14, 2025

Thanks @RobertK0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants