Return 400 error for pacts with invalid JSON

Author: bethesque

lib/pact_broker/api/resources/pact.rb

@@ -20,6 +20,17 @@ def allowed_methods
         ["GET", "PUT"]
       end
 
+      def malformed_request?
+        begin
+          JSON.load(pact_content)
+          false
+        rescue
+          response.headers['Content-Type'] = 'application/json'
+          response.body = {error: 'Invalid JSON'}.to_json
+          true
+        end
+      end
+
       def resource_exists?
         @pact = pact_service.find_pact(identifier_from_path)
         @pact != nil

spec/lib/pact_broker/api/resources/pact_spec.rb

@@ -17,14 +17,20 @@ module Resources
         context "with invalid JSON" do
 
           before do
-            put ""
+            put "/pacts/provider/Provider/consumer/Consumer/version/1.2", '{', {'CONTENT_TYPE' => "application/json"}
           end
 
-          it "returns a 400 response"
+          it "returns a 400 response" do
+            expect(last_response.status).to eq 400
+          end
 
-          it "returns a JSON body"
+          it "returns a JSON content type" do
+            expect(last_response.headers['Content-Type']).to eq "application/json"
+          end
 
-          it "returns an error message"
+          it "returns an error message" do
+            expect(JSON.parse(last_response.body)).to eq "error" => "Invalid JSON"
+          end
         end
       end