You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The method execute_console_command is defined at mods/console/domain/utils.py, and invokes subprocess.run to execute the command, with check parameter set to true. This means that, if the command returns an error code, it will throw a CalledProcessError exception.
As the exception is not being handled, an error will occur if the Git user signing key is not defined. This may happen in several scenarios, most typical of which is a user that does not care about commit signing, and may not even have a key defined (or not know how to do it)
We should not prevent users without signing keys to use the library, so this should be controlled. A warning message may be displayed, but functionality should remain the same.
The text was updated successfully, but these errors were encountered:
When executing the librarian without having defined the user signing key, the following error occurs:
This is caused by the method GitCommandWrapper:get_global_user, in which the following code is executed:
The method execute_console_command is defined at mods/console/domain/utils.py, and invokes subprocess.run to execute the command, with check parameter set to true. This means that, if the command returns an error code, it will throw a CalledProcessError exception.
As the exception is not being handled, an error will occur if the Git user signing key is not defined. This may happen in several scenarios, most typical of which is a user that does not care about commit signing, and may not even have a key defined (or not know how to do it)
We should not prevent users without signing keys to use the library, so this should be controlled. A warning message may be displayed, but functionality should remain the same.
The text was updated successfully, but these errors were encountered: