Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of Gold Image Processing command #89

Open
yeraydavidrodriguez opened this issue Feb 22, 2022 · 0 comments
Open

Improve output of Gold Image Processing command #89

yeraydavidrodriguez opened this issue Feb 22, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yeraydavidrodriguez
Copy link
Collaborator

Currently, the librarian does not support verbosity levels selection: only one "standard" log level is used. The information displayed in this level needs to be improved:

This is the typical output of a gold image processing command run:

image

The output information produced by the librarian is mixed with DVC output, and although each one of the images processed is referenced (many times), not all processes are shown (commits are omitted), and the order is not very clear ("new image found" is shown at the end, and some unexpressive lines with just the ✓ and the filename are shown at the beginning)

We should decide which kind of information is to be displayed, how, and what verbosity levels should be offered to the user to choose from.

This is my preliminary proposal for a "high verbosity" level:

Searching for new gold images...
    000005-32.600.2.tif gold image found
        ✓ Pulling image file from DVC storage 
        ✓ Validating image name and path 
        ✓ Checking image dimensions 
          Image dimensions are 1920 x 1278 
        ✓ Generating base image
          Image file data/000005/42/000005-42.600.2.tif successfully generated 
        ✓ Pushing base image to DVC
        ✓ Committing DVC files to repository
          Commit 13A56B2 successfully created
        ✔ Base image 000005-32.600.2.tif processed successfully
    000005-32.600.2.tif gold image found
        ...
Searching for modified gold images...
    No modified images found
...    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant