Merge pull request #95 from Nautilus-Cyberneering/issue-94-do-not-validate-size-of-renamed-images

Do not validate size for renamed Base images

Author: josecelano

src/nautilus_librarian/typer/commands/workflows/actions/validate_images_dimensions_action.py

@@ -1,5 +1,5 @@
 from nautilus_librarian.mods.dvc.domain.utils import (
-    extract_list_of_media_file_changes_from_dvc_diff_output,
+    extract_added_and_modified_files_from_dvc_diff,
     get_new_filepath_if_is_a_renaming_dict,
 )
 from nautilus_librarian.mods.libvips.domain.validate_image_dimensions import (
@@ -22,7 +22,7 @@ def validate_images_dimensions(dvc_diff, min_image_size, max_image_size):
             ResultCode.CONTINUE, [Message("No Gold image changes found")]
         )
 
-    filenames = extract_list_of_media_file_changes_from_dvc_diff_output(
+    filenames = extract_added_and_modified_files_from_dvc_diff(
         dvc_diff, only_basename=False
     )
 

tests/test_nautilus_librarian/test_typer/test_commands/test_workflows/test_actions/test_validate_images_dimensions_action.py

@@ -52,7 +52,7 @@ def given_a_diff_structure_and_size_limits_it_should_validate_modified_image_dim
     )
 
 
-def given_a_diff_structure_and_size_limits_it_should_validate_renamed_image_dimensions(
+def given_a_diff_structure_and_size_limits_it_should_not_validate_renamed_image_dimensions(
     sample_gold_image_absolute_path,
 ):
 
@@ -70,7 +70,7 @@ def given_a_diff_structure_and_size_limits_it_should_validate_renamed_image_dime
     )
 
     assert result.code == ResultCode.CONTINUE
-    assert result.contains_text(
+    assert not result.contains_text(
         "✓ Dimensions of " + sample_gold_image_absolute_path + " are 1740 x 1160"
     )