Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Warnings for -Wshadow #2491

Closed
LeStarch opened this issue Jan 18, 2024 · 1 comment · Fixed by #2482
Closed

Resolve Warnings for -Wshadow #2491

LeStarch opened this issue Jan 18, 2024 · 1 comment · Fixed by #2482
Labels
enhancement

Comments

@LeStarch
Copy link
Collaborator

F´ Version
Affected Component

Feature Description

Many bits of code in F´ produce warnings when compiling with -Wshadow. We should fix these warnings. The style guidelines inform us that recommended practice is to use m_ prefixes for members to avoid this collision.

Rationale

Code quality.
@LeStarch LeStarch assigned LeStarch and unassigned LeStarch Jan 18, 2024
@LeStarch
Copy link
Collaborator Author

@JohanBertrand is working through this issue.

@LeStarch LeStarch linked a pull request Jan 18, 2024 that will close this issue
Fix shadow variables #2482
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shadow variables JohanBertrand/fprime
1 participant
@LeStarch