Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractCharacterisation is broken #784

Open
rhfogh opened this issue Aug 30, 2023 · 0 comments
Open

AbstractCharacterisation is broken #784

rhfogh opened this issue Aug 30, 2023 · 0 comments

Comments

@rhfogh
Copy link
Collaborator

rhfogh commented Aug 30, 2023

Lookiing at both EDNACharacterisation, and P11EDNACharacterisation, it seems that neither follows the rules of their superclass, AbstractCharacterisation. There are several function signatures in the subclasses that do not follow those in the superclass. In theory the superclass definitions should always take precedence, but in this case it looks like maybe the abstract superclass should be modified to conform to the working implementations.

Anyway, could someone who uses EDNACharacterisation take at look at harmonising this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhfogh