TODO.org

Sendpatch

#+Time-stamp: <2014-06-25 Wed 16:05>

1 Bugs

1.1 Exit with failure if there is some file missing (!)

Currently, because of it goes on, the diff we review in the email is not complete. What’s committed is well complete, hence not what we reviewed!

2 Tasks

2.1 [#A] Add a command-line option to recover last log message

In case the commit failed, to avoid having to retype it all or find and insert the right message.

2.2 [#A] Add a command-line option to allow showing non-whitespace line changes

… remove it (option -x -w of svn diff) by default!

Then, the default behavior is to show all changes (even whitespaces ones).

But, Emacs users (which have deleted many trailing whitespaces) could run sendpatch with that option.

They could even have a spw alias for calling sendpatch with it.

2.3 [#A] Check that the configuration files are in Unix format

Check it, or convert them if needed.

This is a common source of problems…

2.4 Add support of Git

2.5 Move to first editing line with if EDITOR is emacsclient

Run forward-paragraph to skip the comments in the header of the patch file.

Solution (for Cygwin emacs-w32): if EDITOR = emacsclient, set command to

emacsclient -e "(progn (find-file \"0001-.txt\") (beginning-of-buffer) (forward-paragraph))"

Problem: emacsclient does not wait!

2.6 Add ability to add private notes which won’t be committed

2.7 Add the ability to make a review

That is, the title should be “review” instead of “patch” (or “diff”), and no commit should be done.

2.8 Check that related programs are accessible

makelog, makediff, … are needed, so we better check that they’re in the PATH.

2.9 For Unix systems, use the default mail command