[MIG] product_supplierinfo_for_customer_sale: Migration to 11.0

 - New field name from type to supplierinfo_type
 - Remove copyright for __init__.py
 - Re-using variables from tests
 - Manifest bump version and using module url
 - Get commit history from
 https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_sale
    - Run 2to3 script
    - view fixing

Author: xavierjimenez

product_supplierinfo_for_customer_sale/README.rst

@@ -1,11 +1,30 @@
-.. image:: https://img.shields.io/badge/license-AGPL--3-blue.png
-   :target: https://www.gnu.org/licenses/agpl
-   :alt: License: AGPL-3
-
 ======================================
-Product Supplierinfo for customer sale
+Product Supplierinfo for Customer Sale
 ======================================
 
+.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github
+    :target: https://github.com/OCA/sale-workflow/tree/11.0-mig-product_supplierinfo_for_customer_sale/product_supplierinfo_for_customer_sale
+    :alt: OCA/sale-workflow
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/sale-workflow-11-0-mig-product_supplierinfo_for_customer_sale/sale-workflow-11-0-mig-product_supplierinfo_for_customer_sale-product_supplierinfo_for_customer_sale
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
+    :target: https://runbot.odoo-community.org/runbot/167/11.0-mig-product_supplierinfo_for_customer_sale
+    :alt: Try me on Runbot
+
+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
 Based on product_supplierinfo_for_customer, this module loads in every sale order the
 customer code defined in the product and allows
 use the product codes and product name configured in each products in sale
@@ -43,52 +62,56 @@ To use this module, you need:
     :alt: Search by exist customer code
     :width: 600 px
 
-Known issues
-============
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Known issues / Roadmap
+======================
 
 * Putting a minimum qty in a pricelist rule means the system will use the
   option 'list price' instead of any option you chose.
 
 Bug Tracker
 ===========
 
-Bugs are tracked on `GitHub Issues
-<https://github.com/OCA/sale-workflow/issues>`_. In case of trouble, please
-check there if your issue has already been reported. If you spotted it first,
-help us smash it by providing detailed and welcomed feedback.
-
-Usage
-=====
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-workflow/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20product_supplierinfo_for_customer_sale%0Aversion:%2011.0-mig-product_supplierinfo_for_customer_sale%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
-.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
-   :alt: Try me on Runbot
-   :target: https://runbot.odoo-community.org/runbot/95/10.0
+Do not contact contributors directly about support or help with technical issues.
 
 Credits
 =======
 
-Images
-------
+Authors
+~~~~~~~
 
-* Odoo Community Association: `Icon <https://odoo-community.org/logo.png>`_.
+* Agile Business Group
 
 Contributors
-------------
+~~~~~~~~~~~~
 
+* Xavier Jimenez <xavier.jimenez@qubiq.es>
 * Nicola Malcontenti <nicola.malcontenti@agilebg.com>
 * Serpent Consulting Services Pvt. Ltd. <support@serpentcs.com>
 
-Maintainer
-----------
+Maintainers
+~~~~~~~~~~~
+
+This module is maintained by the OCA.
 
 .. image:: https://odoo-community.org/logo.png
    :alt: Odoo Community Association
    :target: https://odoo-community.org
 
-This module is maintained by the OCA.
-
 OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-To contribute to this module, please visit https://odoo-community.org.
+This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/11.0-mig-product_supplierinfo_for_customer_sale/product_supplierinfo_for_customer_sale>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

product_supplierinfo_for_customer_sale/__init__.py

@@ -1,6 +1,3 @@
-# -*- coding: utf-8 -*-
-# Copyright 2013-2017 Agile Business Group sagl
-#     (<http://www.agilebg.com>)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from . import models

product_supplierinfo_for_customer_sale/__manifest__.py

@@ -1,14 +1,13 @@
-# -*- coding: utf-8 -*-
 # Copyright 2013-2017 Agile Business Group sagl
 #     (<http://www.agilebg.com>)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     "name": "Product Supplierinfo for Customer Sale",
-    "version": "10.0.1.0.0",
+    "version": "11.0.1.0.0",
     "summary": "Loads in every sale order line the customer code defined "
                "in the product",
     "author": "Agile Business Group,Odoo Community Association (OCA)",
-    "website": "http://www.agilebg.com",
+    "website": "https://github.com/OCA/sale-workflow/tree/11.0/product_supplierinfo_for_customer_sale", # noqa
     "category": "Sales Management",
     "license": "AGPL-3",
     "depends": [

product_supplierinfo_for_customer_sale/models/__init__.py

@@ -1,6 +1,3 @@
-# -*- coding: utf-8 -*-
-# Copyright 2013-2017 Agile Business Group sagl
-#     (<http://www.agilebg.com>)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from . import sale

product_supplierinfo_for_customer_sale/models/sale.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2013-2017 Agile Business Group sagl
 #     (<http://www.agilebg.com>)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
@@ -18,7 +17,7 @@ def _compute_get_product_customer_code(self):
             code_id = self.env['product.supplierinfo'].search([
                 '|', ('product_tmpl_id', '=', product.product_tmpl_id.id),
                 ('product_id', '=', product.id),
-                ('type', '=', 'customer'),
+                ('supplierinfo_type', '=', 'customer'),
                 ('name', '=', line.order_id.partner_id.id),
             ], limit=1)
             line.product_customer_code = code_id.product_code or ''
@@ -54,7 +53,7 @@ def product_id_change(self):
                 code_id = self.env['product.supplierinfo'].search([
                     '|', ('product_tmpl_id', '=', product.product_tmpl_id.id),
                     ('product_id', '=', product.id),
-                    ('type', '=', 'customer'),
+                    ('supplierinfo_type', '=', 'customer'),
                     ('name', '=', line.order_id.partner_id.id),
                 ], limit=1)
                 if code_id and code_id.min_qty:

product_supplierinfo_for_customer_sale/readme/CONTRIBUTORS.rst

@@ -0,0 +1,3 @@
+* Xavier Jimenez <xavier.jimenez@qubiq.es>
+* Nicola Malcontenti <nicola.malcontenti@agilebg.com>
+* Serpent Consulting Services Pvt. Ltd. <support@serpentcs.com>

product_supplierinfo_for_customer_sale/readme/DESCRIPTION.rst

@@ -0,0 +1,3 @@
+Based on product_supplierinfo_for_customer, this module loads in every sale order the
+customer code defined in the product.
+

product_supplierinfo_for_customer_sale/readme/ROADMAP.rst

@@ -0,0 +1,2 @@
+* Putting a minimum qty in a pricelist rule means the system will use the
+  option 'list price' instead of any option you chose.

product_supplierinfo_for_customer_sale/tests/test_product_name_search.py

@@ -12,7 +12,7 @@ class TestProductNameSearch(TransactionCase):
     """
     def setUp(self):
         super(TestProductNameSearch, self).setUp()
-        self.customer = self.env.ref('base.res_partner_9')
+        self.customer = self.env.ref('base.res_partner_1')
         self.customer_1 = self.env.ref('base.res_partner_2')
         self.product = self.env['product.product'].create(
             {'name': 'Name_product',
@@ -26,7 +26,7 @@ def setUp(self):
             'product_name': 'Name_test',
             'name': self.customer.id,
             'product_tmpl_id': self.product.product_tmpl_id.id,
-            'type': 'customer',
+            'supplierinfo_type': 'customer',
         }
 
     def test_10_find_product_customer_code(self):
@@ -40,24 +40,24 @@ def test_10_find_product_customer_code(self):
 
         # Search by product customer code
         product_names = self.product.name_search(name='code_test')
-        self.assertEquals(len(product_names), 1)
-        self.assertEquals(self.product.id, product_names[0][0])
-        self.assertEquals('[code_test] Name_test', product_names[0][1])
+        self.assertEqual(len(product_names), 1)
+        self.assertEqual(self.product.id, product_names[0][0])
+        self.assertEqual('[code_test] Name_test', product_names[0][1])
 
         # Search by product default code with the customer used in
         # configuration customer
         product_names = self.product.name_search(name='code_product')
-        self.assertEquals(len(product_names), 1)
-        self.assertEquals(self.product.id, product_names[0][0])
-        self.assertEquals('[code_test] Name_test', product_names[0][1])
+        self.assertEqual(len(product_names), 1)
+        self.assertEqual(self.product.id, product_names[0][0])
+        self.assertEqual('[code_test] Name_test', product_names[0][1])
 
         # Search by product default code with a different customer used in
         # configuration customer
         product_names = self.product.with_context(
             partner_id=self.customer_1.id).name_search(name='code_product')
-        self.assertEquals(len(product_names), 1)
-        self.assertEquals(self.product.id, product_names[0][0])
-        self.assertEquals('[code_product] Name_product', product_names[0][1])
+        self.assertEqual(len(product_names), 1)
+        self.assertEqual(self.product.id, product_names[0][0])
+        self.assertEqual('[code_product] Name_product', product_names[0][1])
 
         # Create a product_1 with default_code similar to customer_code of
         # product, then name_search must find two products
@@ -71,7 +71,7 @@ def test_10_find_product_customer_code(self):
 
         # Search by product customer code
         product_names = self.product.name_search(name='code_test')
-        self.assertEquals(len(product_names), 2)
+        self.assertEqual(len(product_names), 2)
         product_names = product_names[0] + product_names[1]
         self.assertIn(self.product.id, product_names)
         self.assertIn(self.product_1.id, product_names)

product_supplierinfo_for_customer_sale/tests/test_product_supplierinfo_for_customer_sale.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2017 Eficent Business and IT Consulting Services S.L.
 #   (http://www.eficent.com)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
@@ -29,19 +28,19 @@ def _create_customer(self, name):
             'phone': 123456,
         })
 
-    def _create_supplierinfo(self, type, partner, product):
-        return self.env['product.supplierinfo'].create({
+    def _create_supplierinfo(self, supplierinfo_type, partner, product):
+        return self.supplierinfo_model.create({
             'name': partner.id,
             'product_id': product.id,
             'product_name': 'product4',
             'product_code': '00001',
-            'type': type,
+            'supplierinfo_type': supplierinfo_type,
             'price': 100.0,
             'min_qty': 15.0,
         })
 
     def _create_pricelist(self, name, product):
-        return self.env['product.pricelist'].create({
+        return self.pricelist_model.create({
             'name': name,
             'currency_id': self.env.ref('base.USD').id,
             'item_ids': [(0, 0, {

product_supplierinfo_for_customer_sale/views/sale_view.xml

@@ -32,9 +32,9 @@
                 <attribute name="string">Supplierinfo</attribute>
             </xpath>
             <filter name="active" position="before">
-                <filter string="Customer" domain="[('type','=','customer')]"
+                <filter string="Customer" domain="[('supplierinfo_type','=','customer')]"
                         name="is_customer_filter"/>
-                <filter string="Supplier" domain="[('type','=','supplier')]"
+                <filter string="Supplier" domain="[('supplierinfo_type','=','supplier')]"
                         name="is_supplier_filter"/>
             </filter>
             <xpath expr="//search/group" position="attributes">
@@ -47,8 +47,8 @@
                             name="gb_product_template"
                             context="{'group_by':'product_tmpl_id'}"/>
                     <separator />
-                    <filter string="Type" domain="[]" name="gb_type"
-                            context="{'group_by':'type'}"/>
+                    <filter string="Type" domain="[]" name="gb_supplierinfo_type"
+                            context="{'group_by':'supplierinfo_type'}"/>
             </xpath>
         </field>
     </record>
@@ -60,14 +60,14 @@
         <field name="priority" eval="20"/>
         <field name="arch" type="xml">
             <xpath expr="//field[@name='order_line']/form//field[@name='product_id']" position="attributes">
-                <attribute name="context">{'partner_id': parent.partner_id, 'quantity': product_uos_qty,
-                'pricelist': parent.pricelist_id, 'uom':product_uom, 'company_id': parent.company_id,
+                <attribute name="context">{'partner_id': parent.partner_id, 'quantity': product_uom_qty,
+                'pricelist': parent.pricelist_id, 'uom': product_uom, 'company_id': parent.company_id,
                 'supplierinfo_type': 'customer'}</attribute>
             </xpath>
             <xpath expr="//field[@name='order_line']/tree//field[@name='product_id']" position="attributes">
-                <attribute name="context">{'partner_id': parent.partner_id, 'quantity': product_uos_qty,
-                'pricelist': parent.pricelist_id, 'uom':product_uom, 'company_id': parent.company_id,
-                'supplierinfo_type': 'customer'}</attribute>
+                <attribute name="context">{'partner_id': parent.partner_id, 'quantity': product_uom_qty,
+                'pricelist': parent.pricelist_id, 'uom': product_uom, 'company_id': parent.company_id,
+                'default_lst_price': price_unit, 'supplierinfo_type': 'customer'}</attribute>
             </xpath>
         </field>
     </record>