Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-actix-web-mozlog: Remove request.summary fields from tracing span #29

Open
mythmon opened this issue Nov 3, 2021 · 0 comments

Comments

@mythmon
Copy link
Contributor

mythmon commented Nov 3, 2021

Currently many fields that are recommended for mozlog's request.summary event are also including the general tracing span values. This makes it harder for downstream consumers to control what is in their logs, and it unneededly bloats each log line in our current JSON formatter (which includes fields from all parent spans in each log line).

We should remove unneeded fields from this span, especially path and agent. The request ID field (rid) should stay in place, so that events can be tied together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant