Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/signer provider issue #21

Closed
wants to merge 3 commits into from
Closed

Conversation

julien-devatom
Copy link
Contributor

Description of change

Fixes: #20

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@julien-devatom julien-devatom requested a review from a team May 24, 2023 15:20
@julien-devatom julien-devatom self-assigned this May 24, 2023
mlgarchery
mlgarchery previously approved these changes May 24, 2023
@julien-devatom julien-devatom requested a review from oumar-fall May 24, 2023 16:45
oumar-fall
oumar-fall previously approved these changes May 24, 2023
Comment on lines +4 to +11
import { MorphoAaveV3Adapter } from "../../src/MorphoAaveV3Adapter";
import { MorphoAaveV3Simulator } from "../../src/simulation/MorphoAaveV3Simulator";
import { ErrorCode, SimulationError } from "../../src/simulation/SimulationError";
import { Operation } from "../../src/simulation/simulation.types";
import { TransactionType } from "../../src/types";
import { Underlying } from "../mocks/markets";
import { ADAPTER_MOCK } from "../mocks/mock";
import configuration from "../../src/configuration";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused imports

@julien-devatom julien-devatom force-pushed the fix/signer-provider-issue branch from e97b0b4 to d98189c Compare May 25, 2023 08:28
@julien-devatom julien-devatom dismissed stale reviews from oumar-fall and mlgarchery via 8dc446a May 25, 2023 08:28
@julien-devatom julien-devatom force-pushed the fix/signer-provider-issue branch from 8dc446a to eb5de9f Compare May 25, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter.connect is not working if the initial fetch has failed.
3 participants