New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue related to Create attempt #9

Closed

HuongNV13 opened this issue Oct 16, 2019 · 1 comment

Collaborator

HuongNV13 commented Oct 16, 2019

We found 2 issues related to Create Attempt:

Create attempt will not work if the Quiz Max Attempt set to unlimited
Create attempt will not work with Moodle master branch (3.8) because the code is using a deprecated function from 3.4 and it will be removed on 3.8
Please refer:

moodle-quiz_answersheets/amd/src/create_attempt_dialog.js

Line 46 in 6f081da

modal.getRoot().on(ModalEvents.yes, params, t.createAttempt);

Need to change from ModalEvents.yes to ModalEvents.save

HuongNV13 mentioned this issue

Fix create an attempt with unlimited attempts and update deprecated ModalEvents.yes #10

Merged

Member

timhunt commented Oct 25, 2019

This is done, so closing.

timhunt closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment