Crossword: declare missing fields for PHP 8.2 #743313

Author: timhunt

question.php

@@ -48,6 +48,19 @@ class qtype_crossword_question extends question_graded_automatically {
     /** @var float The penalty mark for each incorrect accents. */
     public $accentpenalty;
 
+    /** @var string Feedback for any correct response. */
+    public $correctfeedback;
+    /** @var int format of $correctfeedback. */
+    public $correctfeedbackformat;
+    /** @var string Feedback for any partially correct response. */
+    public $partiallycorrectfeedback;
+    /** @var int format of $partiallycorrectfeedback. */
+    public $partiallycorrectfeedbackformat;
+    /** @var string Feedback for any incorrect response. */
+    public $incorrectfeedback;
+    /** @var int format of $incorrectfeedback. */
+    public $incorrectfeedbackformat;
+
     /**
      * Answer field name.
      *

tests/backup_test.php

@@ -218,9 +218,7 @@ public function test_cw_backup_data(string $filename, string $coursefullname, st
                 $filename, $coursefullname, $courseshortname);
         // Assume there is only one crossword question in the DB after restore.
         $questionid = $DB->get_field('question', 'id', ['qtype' => 'crossword'], MUST_EXIST);
-        $q = \question_bank::load_question($questionid);
-        $qtype = new qtype_crossword();
-        $qtype->get_question_options($q);
+        $q = \question_bank::load_question_data($questionid);
         // Verify question exist after restore and question word options is correct.
         $this->assertEquals($questionname, $q->name);
         $count = 0;