Skip to content

Commit c7848ee

Browse files
authored
Merge pull request #1263 from ziegenberg/fix-absolute-links
[docs] fix links to devdocs
2 parents 90cd6f5 + 9aa7b26 commit c7848ee

File tree

1 file changed

+1
-1
lines changed
  • general/development/process/peer-review

1 file changed

+1
-1
lines changed

general/development/process/peer-review/index.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ For automated testing (PHPunit and Behat):
254254
- However, running automated tests takes time and energy. Check that the tests are not excessive, and that they follow best practice (e.g. Behat tests using generators, not setting things up through the UI.) Don't make MDL-15169 worse!
255255
- Not every change in Moodle requires an entire new test. Sometimes, it is more appropriate and efficient to add some checks in an existing tests. (But this should not be taken to excess, since that could lead to a mess where it is not clear what is being tested where.)
256256
- Check that the tests have been added in the best place. Are the tests in a place where someone working on related features in the future will expect to find them.
257-
- As part of your review, check that the unit tests pass. Hopefully this can just be done by checking GitHub actions. (If the developer has not enabled GHA yet, encourage them to do so by linking them to [the instructions](https://moodledev.io/general/development/tools/gha).)
257+
- As part of your review, check that the unit tests pass. Hopefully this can just be done by checking GitHub actions. (If the developer has not enabled GHA yet, encourage them to do so by linking them to [the instructions](../../tools/gha.md).)
258258
- Look for evidence that relevant Behat tests pass, especially when it involved UI changes. Note that Behat is not run by GitHub actions, but all the tests will be run as part of the integration process.
259259

260260
### Overall completeness and correctness

0 commit comments

Comments
 (0)