Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make work packet sizes easily configurable #1281

Open
k-sareen opened this issue Feb 26, 2025 · 2 comments
Open

Make work packet sizes easily configurable #1281

k-sareen opened this issue Feb 26, 2025 · 2 comments

Comments

@k-sareen
Copy link
Collaborator

You'd think that changing the work packet size here would be enough, but actually we need to change the size in VectorQueue as well as in the binding code if it has hardcoded the value. This needs to be fixed with a global constant.

See here for more discussion

@wks
Copy link
Collaborator

wks commented Feb 26, 2025

We can put all the constants in a dedicated module so that they can be easily looked up.

We may also allow the actual work packet sizes to be dynamically set at run time, overriding the defaults provided by constants.

@k-sareen
Copy link
Collaborator Author

Let's just do the former to fix it in the short-term and we can deliberate (on a separate issue) on whether we want to have the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants