Skip to content

Commit f18d03b

Browse files
committed
Migration guide and comment
1 parent 57a9874 commit f18d03b

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

docs/userguide/src/migration/prefix.md

+10
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ API changes:
5555
* `is_movable`
5656
* `is_reachable`
5757
- module `memory_manager`
58+
+ `is_mmtk_object`: It now requires the address parameter to be non-zero and word-aligned.
59+
* Otherwise it will not be a legal `ObjectReference` in the first place. The user should
60+
filter out such illegal values.
5861
+ The following functions no longer have the `<VM>` type argument.
5962
* `find_object_from_internal_pointer`
6063
* `is_in_mmtk_space`
@@ -68,6 +71,13 @@ API changes:
6871
- trait `ObjectModel`
6972
+ `IN_OBJECT_ADDRESS_OFFSET`: removed because it is no longer needed.
7073

74+
See also:
75+
76+
- PR: <https://github.com/mmtk/mmtk-core/issues/1170>
77+
- Examples:
78+
+ https://github.com/mmtk/mmtk-openjdk/pull/286: a simple case
79+
+ https://github.com/mmtk/mmtk-jikesrvm/issues/178: a VM that needs much change for this
80+
7181
## 0.27.0
7282

7383
### `is_mmtk_object` returns `Option<ObjectReference>

src/util/linear_scan.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ pub trait Region: Copy + PartialEq + PartialOrd {
125125
debug_assert!(self.start().as_usize() < usize::MAX - (n << Self::LOG_BYTES));
126126
Self::from_aligned_address(self.start() + (n << Self::LOG_BYTES))
127127
}
128-
/// Return the region that contains the object (by its cell address).
128+
/// Return the region that contains the object.
129129
fn containing(object: ObjectReference) -> Self {
130130
Self::from_unaligned_address(object.to_raw_address())
131131
}

0 commit comments

Comments
 (0)