Skip to content

Commit 451d96c

Browse files
committed
fix Test_PackageRepoDelete
* PackageRepo creation may have slightly slower performance with addition of carvel-dev@b380458 so bumping timeout for test * In event checking if Packages exist fails, kapp delete may not be run for test. Added to cleanUp() func.
1 parent a84a4d1 commit 451d96c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/e2e/package_repo_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,8 @@ spec:
221221
kctl.RunWithOpts([]string{"delete", "package/pkg.test.carvel.dev.2.0.0"}, RunOpts{AllowError: true})
222222
kctl.RunWithOpts([]string{"delete", "packagemetadata/pkg.test.carvel.dev"}, RunOpts{AllowError: true})
223223
kctl.RunWithOpts([]string{"delete", "pkgr/basic.test.carvel.dev"}, RunOpts{AllowError: true})
224+
// kapp delete still needed in event checking if packages existing fails
225+
kapp.Run([]string{"delete", "-a","repo"})
224226
}
225227
defer cleanUp()
226228

@@ -230,7 +232,7 @@ spec:
230232
})
231233

232234
logger.Section("check packages exist", func() {
233-
retry(t, 20*time.Second, func() error {
235+
retry(t, 30*time.Second, func() error {
234236
_, err := kctl.RunWithOpts([]string{"get", "pkgm/pkg.test.carvel.dev"}, RunOpts{AllowError: true})
235237
if err != nil {
236238
return fmt.Errorf("Expected to find pkgm pkg.test.carvel.dev, but couldn't: %v", err)

0 commit comments

Comments
 (0)