Merge pull request #116 from mlr-org/fix-regr.ksvm

RaphaelS1 · web-flow · commit fb4976d195d8 · 2021-10-05T20:41:45.000+01:00
add nu_svr to C parameter
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: mlr3extralearners
 Title: Extra Learners For mlr3
-Version: 0.5.8
+Version: 0.5.9
 Authors@R:
     c(person(given = "Raphael",
              family = "Sonabend",
diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# mlr3extralearners 0.5.9
+
+* Fixed bug that didn't allow C parameter to be set for nu-regression
+
 # mlr3extralearners 0.5.8
 
 * Add `regr.rvm` and `classif.lssvm`
diff --git a/R/learner_kernlab_regr_ksvm.R b/R/learner_kernlab_regr_ksvm.R
@@ -39,7 +39,7 @@ LearnerRegrKSVM = R6Class("LearnerRegrKSVM",
         offset = p_dbl(default = NO_DEF, tags = "train")
       )
 
-      ps$add_dep("C", "type", CondAnyOf$new(c("eps-svr", "eps-bsvr")))
+      ps$add_dep("C", "type", CondAnyOf$new(c("eps-svr", "eps-bsvr", "nu-svr")))
       ps$add_dep("nu", "type", CondAnyOf$new(c("nu-svr")))
       ps$add_dep(
         "epsilon", "type",

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ LearnerRegrKSVM = R6Class("LearnerRegrKSVM",`
`39`	`39`	`offset = p_dbl(default = NO_DEF, tags = "train")`
`40`	`40`	`)`
`41`	`41`
`42`		`- ps$add_dep("C", "type", CondAnyOf$new(c("eps-svr", "eps-bsvr")))`
	`42`	`+ ps$add_dep("C", "type", CondAnyOf$new(c("eps-svr", "eps-bsvr", "nu-svr")))`
`43`	`43`	`ps$add_dep("nu", "type", CondAnyOf$new(c("nu-svr")))`
`44`	`44`	`ps$add_dep(`
`45`	`45`	`"epsilon", "type",`