Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running with --eval val still runs evaluation on the test split #127

Open
joeloskarsson opened this issue Feb 13, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@joeloskarsson
Copy link
Collaborator

As described in

parser.add_argument(
"--eval",
type=str,
help="Eval model on given data split (val/test) "
"(default: None (train model))",
)

running with ---eval val should evaluate the model on the validation split. This used to be the case, but when the data module was introduced this was apparently changed so that evaluation always happens with the test set
if stage == "test" or stage is None:
self.test_dataset = WeatherDataset(
datastore=self._datastore,
split="test",
ar_steps=self.ar_steps_eval,
standardize=self.standardize,
num_past_forcing_steps=self.num_past_forcing_steps,
num_future_forcing_steps=self.num_future_forcing_steps,
)

This is both an error in documentation, but I think we should keep the possibility to run eval separately for the full validation set, as this is highly useful. Here is a possible fix that allows for this: joeloskarsson@deec455

@joeloskarsson joeloskarsson added the bug Something isn't working label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant