32b support

[gregtatcam]

run 'ogit clone --bare remote-repo local-repo', then cd to local-repo and run 'git reset master --hard'. Get errors:

error: wrong index v2 file size in .git/objects/pack/pack-88a6bbf29934073da5deb72f2baadacd365dcda9.idx
error: wrong index v2 file size in .git/objects/pack/pack-88a6bbf29934073da5deb72f2baadacd365dcda9.idx
fatal: Could not parse object 'master'.

Git version 1.6.2.

[samoht]

Is it easily reproducible? Which remote repo? Did you set up a depth parameter?

On 17 Jul 2015, at 13:06, gregtatcam notifications@github.com wrote:

run 'ogit clone --bare remote-repo local-repo', then cd to local-repo and run 'git reset master --hard'. Get errors:

error: wrong index v2 file size in .git/objects/pack/pack-88a6bbf29934073da5deb72f2baadacd365dcda9.idx
error: wrong index v2 file size in .git/objects/pack/pack-88a6bbf29934073da5deb72f2baadacd365dcda9.idx
fatal: Could not parse object 'master'.

Git version 1.6.2.

—
Reply to this email directly or view it on GitHub.

[gregtatcam]

it happens with just one file in the repository. It only happens on rPi. I didn't set the depth.

• create a repo
  git init repo; cd repo; echo "a" > a; git add -A; git commit -m "a"
• run daemon
  git daemon --export-all --reuseaddr --base-path=/ /
• clone
  ogit clone --bare repo
  I compared .git/index and .git/objects/pack/*.idx on MAC and rPi and they are different. I can send tar of the repo if it helps.

[gregtatcam]

I built 32-bit Ubuntu 15.04 for Virtual Box. The issue is reproducible on this system. I can provide the image.

[samoht]

Thanks for the report! I looks like a 64b overflow in the sizes/offsets handling in the pack file. Should be easy to fix.

[gregtatcam]

Great!

On Jul 18, 2015, at 4:09 PM, Thomas Gazagnaire notifications@github.com wrote:

Thanks for the report! I looks like a 64b overflow in the sizes/offsets handling in the pack file. Should be easy to fix.

—
Reply to this email directly or view it on GitHub #105 (comment).

[samoht]

This is actually a bit harder than I though, as it might need a custom layer on top of bigarrays to deal with large files (both cstruct and mstruct do not work well on 32b platforms it seems...)

[samoht]

See mirage/ocaml-cstruct#71