Missing keepalive parameter in nginx configuration

[ldumaine]

Hi,

I think the proposed nginx configuration doesn't activate keepalive connexions as the upstream server doesn't include the keepalive parameter that activates the cache for connections to upstream servers.

https://nginx.org/en/docs/http/ngx_http_upstream_module.html#keepalive

See there for example
https://github.com/minio/minio/blob/39df134204b17336b133ab22256ac17fe72adcd6/docs/resiliency/nginx.conf
Or there:
https://min.io/docs/minio/linux/integrations/setup-nginx-proxy-with-minio.html

Without the keepalive parameter
$mc ping -c 100 ssd|tail -n 5
96: https://fsdfdsl min=1.39ms max=18.54ms average=8.34ms errors=0 roundtrip=12.98ms
97: https://fsdfdsl min=1.39ms max=18.54ms average=8.29ms errors=0 roundtrip=4.01ms
98: https://fsdfdsl min=1.39ms max=18.54ms average=8.25ms errors=0 roundtrip=3.93ms
99: https://fsdfdsl min=1.39ms max=18.54ms average=8.18ms errors=0 roundtrip=1.54ms
100: https://fsdfdsl min=1.39ms max=18.54ms average=8.12ms errors=0 roundtrip=1.79ms

With the keepalive parameter (keepalive 48)
$mc ping -c 100 ssd | tail -n 5
96: https://fdsfds min=0.97ms max=16.60ms average=2.16ms errors=0 roundtrip=1.88ms
97: https://fdsfds min=0.97ms max=16.60ms average=2.16ms errors=0 roundtrip=1.93ms
98: https://fsdfdsl min=0.97ms max=16.60ms average=2.15ms errors=0 roundtrip=1.12ms
99: https://fdsfds min=0.97ms max=16.60ms average=2.14ms errors=0 roundtrip=1.37ms
100: https://fdsfsd min=0.97ms max=16.60ms average=2.13ms errors=0 roundtrip=1.30ms

Regards, Luc.

[klauspost]

The stuff in the minio repo is not to be used, but the docs should be fixed.

[ravindk89]

So the webdocs do not mention setting keepalive at at all - if we do mention it, it has to include a baseline parameter value that we believe to be generally 'safe'. I'm not sure what that value would be.

@allanrogerr any guidance here?