Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio Enterprise 2022 Preview reports upgrade, while latest version is already installed #232257

Open
vbaderks opened this issue Feb 19, 2025 · 2 comments
Labels
Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated

Comments

@vbaderks
Copy link

Brief description of your issue

using winget upgrade it shows:

Name                                  Id                                             Version             Available Source
-------------------------------------------------------------------------------------------------------------------------
Visual Studio Enterprise 2022 Preview Microsoft.VisualStudio.2022.Enterprise.Preview 17.14.0 Preview 1.0 17.14.0   winget

Steps to reproduce

run winget upgrade

Expected behavior

At this moment (2025-2-19) version 17.14.0 Preview 1.0 is the latest version. No upgrade should be offered.

Actual behavior

Upgrade if offered, after the installtion upgrade is still offered as offical installer sees that nothing needs to be done.

Environment

Windows Package Manager v1.10.300
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26100.3194
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.25.300.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads
Configuration Modules              %LOCALAPPDATA%\Microsoft\WinGet\Configuration\Modules

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Feb 19, 2025
@stephengillie
Copy link
Collaborator

Since the issue only impacts 1 package, and seems to be fixalbe through manifests, this Issue should probably be moved to the winget-pkgs repo.

It seems that version 17.14.0 Preview 1.0 is newer than 17.14.0, which is the newest version in our repo. It contains versions:

PS C:\ManVal> (Find-WinGetPackage Microsoft.VisualStudio.2022.Enterprise.Preview).AvailableVersions
17.14.0
17.13.0
17.12.0
17.11.0
17.10.0
17.9.0
17.8.0
17.7.0
17.6.0
17.5.0

Normally, the package manager would show a + next to the version number, to indicate that the installed version is higher than the highest version it has in repo. But here, I'm guessing the spaces in the installed version number might be confusing the package manager, causing it to be sorted below 17.14.0. And so the package manager offers 17.14.0, as the item at the top of the list.

I'm not completely sure, but I believe the solution might involve adding a manifest for 17.14.0 Preview 1.0 to the repo. This would allow the package manager to match the package with a manifest in repo. And from there, we could work to fix the sorting issues through manifest updates.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Feb 20, 2025
@vbaderks
Copy link
Author

@stephengillie . I also do think that this is more something for the winget-pkgs repo, feel free to move it.

Note: Microsoft release several preview versions of Visual Studio, they are often called:
17.14.0. Preview 1.0, 17.14.0. Preview 2.0, etc. They have followed this pattern also for the 17.13.0 preview and older series.

@denelon denelon transferred this issue from microsoft/winget-cli Feb 21, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Feb 21, 2025
@stephengillie stephengillie added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated
Projects
None yet
Development

No branches or pull requests

2 participants